fix: block VM creation/save with invalid CloudInit YAML (#1040)

* fix(vm): block VM creation with invalid CloudInit YAML content

* fix(vm): add isWindows guard to validateCloudInit in template version

* fix: validate Windows CloudInit YAML on save

Co-authored-by: a110605 <5744158+a110605@users.noreply.github.com>

* fix: validate cloud-init by format in the VM mixin

Cloud-init picks the user data format from the first line, so scripts,
MIME messages and Jinja templates are valid without being YAML. Parsing
all user data blocked them, and it stopped any existing VM holding one
from being saved, even with nothing changed.

Only parse user data that starts with #cloud-config, and require a
mapping for it and for network data, because plain words are valid YAML
and were still saved.

Both forms already use the VM mixin, so the check moves there and shares
the header pattern with hasCloudConfigComment.

Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>

* fix: save other user data formats as typed and check text without a header

The form added #cloud-config to any user data that parses as YAML, so a
script was saved with the header and its lines folded together, and Edit
Config then failed the check on it. User data that starts with a script,
MIME or another cloud-init or Cloudbase-Init format is now saved as typed,
and any other text is checked as cloud-config, with or without the header,
because the form adds the header when saving it.

Editing only checks cloud-init that changed, so a VM saved before this
change can still be edited with the cloud-init it already has.

Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>

---------

Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: a110605 <5744158+a110605@users.noreply.github.com>
Co-authored-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
(cherry picked from commit aa6d11a840)

pkg/harvester/edit/kubevirt.io.virtualmachine/__tests__/index.test.js

@@ -0,0 +1,37 @@
+import VM_MIXIN from '@pkg/harvester/mixins/harvester-vm';
+import HarvesterEditVM from '../index.vue';
+
+function saveWith(userScript) {
+  const buttonCb = jest.fn();
+  const form = {
+    userScript,
+    errors:                 [],
+    isSingle:               true,
+    t:                      (key) => key,
+    validateCPUMemory:      jest.fn(),
+    validateWindowsSysprep: jest.fn(),
+    validateCloudInit:      VM_MIXIN.methods.validateCloudInit,
+    saveSingle:             jest.fn(),
+  };
+
+  HarvesterEditVM.methods.saveVM.call(form, buttonCb);
+
+  return { form, buttonCb };
+}
+
+describe('page: kubevirt.io.virtualmachine edit', () => {
+  it('should stop the save when the cloud config is invalid', () => {
+    const { form, buttonCb } = saveWith('#cloud-config\nsome words\n');
+
+    expect(form.errors).toStrictEqual(['harvester.virtualMachine.cloudConfig.user.invalidYaml']);
+    expect(buttonCb).toHaveBeenCalledWith(false);
+    expect(form.saveSingle).not.toHaveBeenCalled();
+  });
+
+  it('should save when the user data is a script', () => {
+    const { form, buttonCb } = saveWith('#!/bin/bash\napt-get update\n# start it\nsystemctl enable --now nginx\n');
+
+    expect(form.errors).toStrictEqual([]);
+    expect(form.saveSingle).toHaveBeenCalledWith(buttonCb);
+  });
+});

pkg/harvester/edit/kubevirt.io.virtualmachine/index.vue

@@ -379,6 +379,7 @@ export default {
 
       this.validateCPUMemory();
       this.validateWindowsSysprep();
+      this.validateCloudInit();
 
       // block create VM flow if has validation errors
       if (this.errors.length) {