mirror of
https://github.com/harvester/harvester-ui-extension.git
synced 2026-11-22 00:27:38 +08:00
* feat: page the VM list on the server when the API supports it On clusters whose API serves lists from the Steve SQL cache, the VM list uses PaginatedResourceTable: it loads one page of VMs, and the VMIs, pods, PVCs, PVs, migrations, restores and backups of those VMs only. Sorting, search and the namespace filter run on the server, so CPU, memory, IP and node can't be sorted or searched there. The feature is gated by the vmListPagination feature flag and enabled for the VM list only, through a pagination context. Older clusters keep the current list. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * feat: enable the VM list pagination from v1.10.0 The backend change that serves API lists from the SQL cache has to be on the v1.10 branch before this is merged. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: keep the paged VM list when adding a volume The Add Volume dialog loaded every VM to find the volumes in use, which replaced the page the VM list keeps in the store and emptied the list. When the list is paged, the dialog now reads only the VMs of the namespace and doesn't store them. The requests for the resources of a page use one IN filter instead of one filter per value, which keeps the URLs about a third as long. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: keep the paged VM list intact in its dialogs and on older APIs The Add Volume, Storage Migration and Restore dialogs read the VMs, PVCs and backups of the VM's namespace through the VM. While the list keeps a page of a type in the store they read the namespace without storing it, so the list keeps its page and the dialogs' own lists don't shrink when the page reloads. Storage Migration no longer offers volumes of VMs on other pages as targets. The list is paged only when the API lists the VM's printer columns as metadata.fields, which the SQL cache does, so a missing or non-semver server version can't turn it on against an API that can't filter. One failed request for a page's resources no longer stops the others. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: show the restart notice only when its VMs change The list rebuilds the names of the VMs that need a restart on every refresh, and when it pages also on every page, sort and search, so the notice popped up again each time even when nothing new needed a restart. Show it only when the set of VMs changes. While paging it still covers only the VMs on the current page: the API can't filter VMs by their RestartRequired condition. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: find the launcher pods of every VM on the page The paged list loaded the page's launcher pods by the harvesterhci.io/vmName label, which only the Harvester VM form writes into a VM's template. VMs created any other way, like an imported VM or one applied with kubectl, got no pod, so their rows lost View Logs and the starting and pod error states. Load the pods after the page's VMIs instead, by the kubevirt.io/created-by label KubeVirt puts on every launcher pod (the VMI's UID). Also cover the paged mode in the tests: it must not load every VMI, migration or pod, and a forced refresh must reach every request. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: notify about restarts again when coming back to the VM list The restart notice compared the VMs that need a restart with the previous value of the list. Coming back from a page that loads every VM, like Volumes or a VM's detail page, that previous value already held the same VMs, so the notice didn't show. Remember what was notified on the list itself instead, so each visit starts fresh, and compare by namespace and name, so a VM of the same name in another namespace counts as a change. Also say which VMs lack Harvester's vmName label: the ones from Forklift or plain manifests, not every VM created outside the UI. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * refactor: keep the VM list's paging helpers in the component Only canPaginate stays outside, because ResourceList calls $loadingResources(route, store) on the component options, where there is no `this`. The pagination headers become a computed property and the printer column lookup a method. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * refactor: always list VMs with PaginatedResourceTable PaginatedResourceTable handles both modes. fetchSecondaryResources loads every pod, volume, restore, backup, VMI and migration when the list isn't paged, and only what every row shares when it is. VMIs without a VM are added back through localFilter, which only runs without pagination. The list passes the pagination context only when the cluster's API can page, so older clusters keep the full list. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * refactor: register the VM list's columns with the product Both column sets go through the product's headers(), with the paged set next to the unpaged one in config/table-headers.js. The list only adds the node and restore progress columns, which the API can't sort or search when paging. State sorts by the VM's Status printer column, metadata.fields.2. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: show the restart notice when coming back to the VM list Since the list always uses PaginatedResourceTable it reads the VMs from the store. Coming back to the list the store already holds them, so the restart watcher never saw a change and the notice didn't show. Run it when the list is created too. While paging, the store can still hold the VMs another view loaded, like every VM after Volumes or a VM's detail, so wait for the list's own page before notifying. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: let the namespace filter know the VM list is paged The VMs were registered for pagination with a context that only the VM list passed. The header's namespace filter asks without one, so it didn't know the list was paged and kept offering "Not in a Project", which the paged API can't filter by: picking it hid every VM. Register the VMs in every context and answer per cluster in the store's paginationEnabled getter instead: only when the feature is on and the API lists the VM's printer columns as metadata.fields, as the SQL cache does. The filter, the list and the store now agree, and clusters whose API can't page keep the full list. The filter is shared by every list, so Not in a Project can still be picked on a list that doesn't page. The paged VM list then asks for another option, like the shell's generic lists do, instead of showing no rows. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * fix: keep the paged VM list when showing a VM's configuration The Config tab of the Show Configuration drawer renders the VM form, which loads every VM, PVC, PV, VMI and migration, and its device tabs every VM again. On a paged list that replaced the list's page in the store and emptied the list. Hide the Config tab while the store keeps a page of VMs, so the drawer shows the YAML. The VM's own page still shows its configuration, and a drawer opened where every VM is loaded keeps its Config tab. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> * refactor: define the VM list's node and restore columns with the others The node and restore progress columns are now in VM_HEADERS, so the paged set turns their sort and search off through VM_PAGINATION_FIELDS, like the other columns the API can't index. The list only leaves them out when they don't apply: the node column when the cluster's nodes can't be seen, the restore progress while no backup is being restored. Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com> --------- Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>