mirror of
https://github.com/harvester/harvester-ui-extension.git
synced 2026-10-08 23:26:08 +08:00
Compare commits
74
Commits
main
..
v1.9.1-rc3
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
fb190996b6 | ||
|
|
1c8880d9b0 | ||
|
|
bcd8929ba3 | ||
|
|
24834396b9 | ||
|
|
280878ebb3 | ||
|
|
51da6a551c | ||
|
|
010dd710fc | ||
|
|
788c583210 | ||
|
|
ee8f214b7f | ||
|
|
27c1e64a05 | ||
|
|
68d67a7cbc | ||
|
|
6a7691456f | ||
|
|
66f6c36759 | ||
|
|
eb77d03b97 | ||
|
|
22deb0e1f6 | ||
|
|
f096147aa3 | ||
|
|
d73a9413be | ||
|
|
63ff8ce8fe | ||
|
|
b3b467f7b5 | ||
|
|
20557ee788 | ||
|
|
8ab432fb52 | ||
|
|
61624dc0ff | ||
|
|
d1367fc9a9 | ||
|
|
18c973c8c4 | ||
|
|
c9b26ab4bb | ||
|
|
2b9d093b38 | ||
|
|
1b3666e15c | ||
|
|
0bccb9a71f | ||
|
|
6d4cd09568 | ||
|
|
44078bf7cb | ||
|
|
1d55319aba | ||
|
|
3b7a0c30a7 | ||
|
|
d4562a91d1 | ||
|
|
080f9cdb29 | ||
|
|
b19da16b83 | ||
|
|
16a92c5e96 | ||
|
|
51a76eefe2 | ||
|
|
690652f204 | ||
|
|
a0f21d5902 | ||
|
|
f0929100f0 | ||
|
|
78ca4bb663 | ||
|
|
eb917c9d18 | ||
|
|
8815c70361 | ||
|
|
eb4c0504c8 | ||
|
|
82e7b0da19 | ||
|
|
92f34fa64f | ||
|
|
6039f21320 | ||
|
|
3cbaf97399 | ||
|
|
bcde1744e1 | ||
|
|
e991c9bcc8 | ||
|
|
6e709bc00f | ||
|
|
20d40860ce | ||
|
|
1496c17f3d | ||
|
|
e99e4ef34f | ||
|
|
73e022172b | ||
|
|
7e86c9fae0 | ||
|
|
b4b49222c3 | ||
|
|
b937a2147b | ||
|
|
07f2b02a9d | ||
|
|
35b6949cdc | ||
|
|
c577f589e7 | ||
|
|
b1387820ed | ||
|
|
45f72749f5 | ||
|
|
a65b3f443e | ||
|
|
21d415b5f3 | ||
|
|
7493fe2dfc | ||
|
|
e71d12f67f | ||
|
|
d3b77e2e41 | ||
|
|
73126b953c | ||
|
|
937afd9c9a | ||
|
|
3658caf067 | ||
|
|
a067751cba | ||
|
|
94566b2b54 | ||
|
|
d47bf1d712 |
@@ -8,16 +8,12 @@
|
|||||||
- [ ] Yes, the backend owner is @
|
- [ ] Yes, the backend owner is @
|
||||||
- [ ] No, frontend-only.
|
- [ ] No, frontend-only.
|
||||||
|
|
||||||
### Related Issue
|
### Related Issue #
|
||||||
<!-- Link the issue as harvester/harvester#<issue_number> -->
|
<!-- Link the issue as harvester/harvester#<issue_number> -->
|
||||||
harvester/harvester#<issue_number>
|
harvester/harvester#<issue_number>
|
||||||
|
|
||||||
|
|
||||||
### Test Steps
|
### Test screenshot or video (Required)
|
||||||
<!-- Provide the test steps for reviewer to verify the issue -->
|
<!-- Attach screenshot or video of the changes and eventual comparison if you find it necessary -->
|
||||||
1. Go to ... page
|
|
||||||
|
|
||||||
### Test screenshot or video
|
|
||||||
<!-- Attach screenshot or video of the changes and eventual comparison -->
|
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -1,7 +1,6 @@
|
|||||||
name: Build Standalone on PR Merge
|
name: Build Standalone on PR Merge
|
||||||
|
|
||||||
on:
|
on:
|
||||||
workflow_dispatch: # manually trigger on Github Actions only support PR branch pushed to harvester/harvester-ui-extension
|
|
||||||
push:
|
push:
|
||||||
branches:
|
branches:
|
||||||
- main
|
- main
|
||||||
@@ -30,35 +29,3 @@ jobs:
|
|||||||
id-token: write
|
id-token: write
|
||||||
with:
|
with:
|
||||||
CI_BRANCH: ${{github.ref_name}}
|
CI_BRANCH: ${{github.ref_name}}
|
||||||
comment-on-pr:
|
|
||||||
name: Comment build result on PR
|
|
||||||
# Only for manual runs so the existing push / pull_request flows are untouched.
|
|
||||||
if: github.event_name == 'workflow_dispatch'
|
|
||||||
needs:
|
|
||||||
- build
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
permissions:
|
|
||||||
pull-requests: write
|
|
||||||
steps:
|
|
||||||
- name: Add build artifact comment to the PR opened from this branch
|
|
||||||
env:
|
|
||||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
||||||
BRANCH: ${{ github.ref_name }}
|
|
||||||
run: |
|
|
||||||
set -euo pipefail
|
|
||||||
# Match scripts/version: sanitize the branch and map main -> latest.
|
|
||||||
if [ "$BRANCH" = "main" ]; then
|
|
||||||
DIR="latest"
|
|
||||||
else
|
|
||||||
DIR=$(printf '%s' "$BRANCH" | sed -E 's/[^a-zA-Z0-9.-]+/-/g')
|
|
||||||
fi
|
|
||||||
URL="https://releases.rancher.com/harvester-ui/dashboard/${DIR}/index.html"
|
|
||||||
|
|
||||||
PR=$(gh pr list --repo "$GITHUB_REPOSITORY" --state open --base main --head "$BRANCH" --json number --jq '.[0].number // empty')
|
|
||||||
if [ -z "$PR" ]; then
|
|
||||||
echo "No open PR found for branch $BRANCH, skipping comment."
|
|
||||||
exit 0
|
|
||||||
fi
|
|
||||||
|
|
||||||
BODY=$(printf '🚀 **UI Artifact Build Status:** `SUCCESS` ✅\n> ui-index: %s\n> ui-source: external' "$URL")
|
|
||||||
gh pr comment "$PR" --repo "$GITHUB_REPOSITORY" --body "$BODY"
|
|
||||||
|
|||||||
+6
-8
@@ -1,13 +1,13 @@
|
|||||||
{
|
{
|
||||||
"name": "harvester-ui-extension",
|
"name": "harvester-ui-extension",
|
||||||
"version": "1.10.0-dev",
|
"version": "1.9.1-rc3",
|
||||||
"private": false,
|
"private": false,
|
||||||
"engines": {
|
"engines": {
|
||||||
"node": ">=24.0.0"
|
"node": ">=24.0.0"
|
||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@babel/plugin-transform-class-static-block": "7.29.7",
|
"@babel/plugin-transform-class-static-block": "7.29.7",
|
||||||
"@rancher/shell": "3.0.13",
|
"@rancher/shell": "3.0.12-rc.7",
|
||||||
"@vue-flow/background": "^1.3.0",
|
"@vue-flow/background": "^1.3.0",
|
||||||
"@vue-flow/controls": "^1.1.1",
|
"@vue-flow/controls": "^1.1.1",
|
||||||
"@vue-flow/core": "^1.33.5",
|
"@vue-flow/core": "^1.33.5",
|
||||||
@@ -27,7 +27,7 @@
|
|||||||
"yaml": "^2.5.1"
|
"yaml": "^2.5.1"
|
||||||
},
|
},
|
||||||
"resolutions": {
|
"resolutions": {
|
||||||
"@types/node": "25.9.6",
|
"@types/node": "25.9.5",
|
||||||
"cronstrue": "2.59.0",
|
"cronstrue": "2.59.0",
|
||||||
"d3-color": "3.1.0",
|
"d3-color": "3.1.0",
|
||||||
"ejs": "3.1.10",
|
"ejs": "3.1.10",
|
||||||
@@ -48,17 +48,15 @@
|
|||||||
"dev": "NODE_ENV=dev ./node_modules/.bin/vue-cli-service serve",
|
"dev": "NODE_ENV=dev ./node_modules/.bin/vue-cli-service serve",
|
||||||
"build": "./node_modules/.bin/vue-cli-service build",
|
"build": "./node_modules/.bin/vue-cli-service build",
|
||||||
"clean": "./node_modules/@rancher/shell/scripts/clean",
|
"clean": "./node_modules/@rancher/shell/scripts/clean",
|
||||||
"lint": "./node_modules/@rancher/shell/scripts/lint --max-warnings 0 --ext .js,.ts,.vue .",
|
"lint": "./node_modules/.bin/eslint --max-warnings 0 --ext .js,.ts,.vue .",
|
||||||
"lint:fix": "./node_modules/@rancher/shell/scripts/lint --fix --max-warnings 0 --ext .js,.ts,.vue .",
|
"lint:fix": "./node_modules/.bin/eslint --fix --max-warnings 0 --ext .js,.ts,.vue .",
|
||||||
"build-pkg": "./node_modules/@rancher/shell/scripts/build-pkg.sh",
|
"build-pkg": "./node_modules/@rancher/shell/scripts/build-pkg.sh",
|
||||||
"serve-pkgs": "./node_modules/@rancher/shell/scripts/serve-pkgs",
|
"serve-pkgs": "./node_modules/@rancher/shell/scripts/serve-pkgs",
|
||||||
"publish-pkgs": "./node_modules/@rancher/shell/scripts/extension/publish",
|
"publish-pkgs": "./node_modules/@rancher/shell/scripts/extension/publish",
|
||||||
"parse-tag-name": "./node_modules/@rancher/shell/scripts/extension/parse-tag-name",
|
"parse-tag-name": "./node_modules/@rancher/shell/scripts/extension/parse-tag-name",
|
||||||
"commitlint": "commitlint --edit",
|
"commitlint": "commitlint --edit",
|
||||||
"prepare": "husky",
|
"prepare": "husky",
|
||||||
"agents:generate": "./scripts/generate-agent-and-persona-mds.sh",
|
"agents:generate": "./scripts/generate-agent-and-persona-mds.sh"
|
||||||
"prelint": "npm --prefix node_modules/@rancher/shell/eslint-legacy install eslint-plugin-jest@^24 --no-save --no-audit --no-fund --legacy-peer-deps --loglevel=error",
|
|
||||||
"prelint:fix": "npm --prefix node_modules/@rancher/shell/eslint-legacy install eslint-plugin-jest@^24 --no-save --no-audit --no-fund --legacy-peer-deps --loglevel=error"
|
|
||||||
},
|
},
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
"@commitlint/load": "^19.8.1",
|
"@commitlint/load": "^19.8.1",
|
||||||
|
|||||||
@@ -81,10 +81,7 @@ const FEATURE_FLAGS = {
|
|||||||
'lvmDmThinOnly',
|
'lvmDmThinOnly',
|
||||||
'highPerformanceStorage',
|
'highPerformanceStorage',
|
||||||
],
|
],
|
||||||
'v1.10.0': [
|
'v1.10.0': [],
|
||||||
'maintenanceModeConditions',
|
|
||||||
'maintenanceModeDrainTimeoutSetting',
|
|
||||||
],
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const generateFeatureFlags = () => {
|
const generateFeatureFlags = () => {
|
||||||
|
|||||||
@@ -39,21 +39,6 @@ export const VOLUME_TYPE = [{
|
|||||||
value: 'cd-rom'
|
value: 'cd-rom'
|
||||||
}];
|
}];
|
||||||
|
|
||||||
// KubeVirt high-performance disk features
|
|
||||||
// https://kubevirt.io/user-guide/storage/disks_and_volumes/#high-performance-features
|
|
||||||
export const DISK_CACHE_MODE = ['', 'none', 'writeback', 'writethrough'];
|
|
||||||
|
|
||||||
export const DISK_IO_MODE = ['', 'native', 'threads'];
|
|
||||||
|
|
||||||
export const IO_THREADS_POLICY = ['', 'shared', 'auto', 'supplementalPool'];
|
|
||||||
|
|
||||||
// "Easy-to-consume" presets layered on top of the raw KubeVirt fields.
|
|
||||||
export const DISK_PERFORMANCE_PROFILE = {
|
|
||||||
DEFAULT: 'default',
|
|
||||||
HIGH: 'highPerformance',
|
|
||||||
CUSTOM: 'custom',
|
|
||||||
};
|
|
||||||
|
|
||||||
export const VOLUME_HOTPLUG_ACTION = {
|
export const VOLUME_HOTPLUG_ACTION = {
|
||||||
INSERT_CDROM_IMAGE: 'INSERT_CDROM_IMAGE',
|
INSERT_CDROM_IMAGE: 'INSERT_CDROM_IMAGE',
|
||||||
EJECT_CDROM_IMAGE: 'EJECT_CDROM_IMAGE',
|
EJECT_CDROM_IMAGE: 'EJECT_CDROM_IMAGE',
|
||||||
|
|||||||
@@ -22,7 +22,7 @@ export const HCI = {
|
|||||||
VM_NAME_PREFIX: 'harvesterhci.io/vmNamePrefix',
|
VM_NAME_PREFIX: 'harvesterhci.io/vmNamePrefix',
|
||||||
VM_DISPLAY_NAME: 'harvesterhci.io/vmDisplayName',
|
VM_DISPLAY_NAME: 'harvesterhci.io/vmDisplayName',
|
||||||
VM_RESERVED_MEMORY: 'harvesterhci.io/reservedMemory',
|
VM_RESERVED_MEMORY: 'harvesterhci.io/reservedMemory',
|
||||||
MAINTENANCE_STATUS: 'harvesterhci.io/maintain-status', // Deprecated >= v1.10.0
|
MAINTENANCE_STATUS: 'harvesterhci.io/maintain-status',
|
||||||
HOST_CUSTOM_NAME: 'harvesterhci.io/host-custom-name',
|
HOST_CUSTOM_NAME: 'harvesterhci.io/host-custom-name',
|
||||||
HOST_CONSOLE_URL: 'harvesterhci.io/host-console-url',
|
HOST_CONSOLE_URL: 'harvesterhci.io/host-console-url',
|
||||||
RESTORE_NAME: 'restore.harvesterhci.io/name',
|
RESTORE_NAME: 'restore.harvesterhci.io/name',
|
||||||
@@ -33,11 +33,6 @@ export const HCI = {
|
|||||||
CLONE_BACKEND_STORAGE_STATUS: 'harvesterhci.io/clone-backend-storage-status',
|
CLONE_BACKEND_STORAGE_STATUS: 'harvesterhci.io/clone-backend-storage-status',
|
||||||
MIGRATION_STATE: 'harvesterhci.io/migrationState',
|
MIGRATION_STATE: 'harvesterhci.io/migrationState',
|
||||||
VOLUME_CLAIM_TEMPLATE: 'harvesterhci.io/volumeClaimTemplates',
|
VOLUME_CLAIM_TEMPLATE: 'harvesterhci.io/volumeClaimTemplates',
|
||||||
// Default KubeVirt high-performance disk settings, applied when the volume is
|
|
||||||
// attached to a VM as a disk. See disks_and_volumes.md#high-performance-features.
|
|
||||||
DISK_CACHE_MODE: 'harvesterhci.io/disk-cache-mode',
|
|
||||||
DISK_IO_MODE: 'harvesterhci.io/disk-io-mode',
|
|
||||||
DISK_DEDICATED_IOTHREAD: 'harvesterhci.io/disk-dedicated-iothread',
|
|
||||||
IMAGE_NAME: 'harvesterhci.io/image-name',
|
IMAGE_NAME: 'harvesterhci.io/image-name',
|
||||||
INIT_IP: 'etcd.rke2.cattle.io/node-address',
|
INIT_IP: 'etcd.rke2.cattle.io/node-address',
|
||||||
NODE_SCHEDULABLE: 'kubevirt.io/schedulable',
|
NODE_SCHEDULABLE: 'kubevirt.io/schedulable',
|
||||||
|
|||||||
@@ -45,8 +45,7 @@ export const HCI_SETTING = {
|
|||||||
MAX_HOTPLUG_RATIO: 'max-hotplug-ratio',
|
MAX_HOTPLUG_RATIO: 'max-hotplug-ratio',
|
||||||
KUBEVIRT_MIGRATION: 'kubevirt-migration',
|
KUBEVIRT_MIGRATION: 'kubevirt-migration',
|
||||||
INSTANCE_MANAGER_RESOURCES: 'instance-manager-resources',
|
INSTANCE_MANAGER_RESOURCES: 'instance-manager-resources',
|
||||||
CLUSTER_POD_SECURITY_STANDARD: 'cluster-pod-security-standard',
|
CLUSTER_POD_SECURITY_STANDARD: 'cluster-pod-security-standard'
|
||||||
MAINTENANCE_MODE_DRAIN_TIMEOUT: 'maintenance-mode-drain-timeout'
|
|
||||||
};
|
};
|
||||||
|
|
||||||
export const HCI_ALLOWED_SETTINGS = {
|
export const HCI_ALLOWED_SETTINGS = {
|
||||||
@@ -149,9 +148,6 @@ export const HCI_ALLOWED_SETTINGS = {
|
|||||||
},
|
},
|
||||||
[HCI_SETTING.CLUSTER_POD_SECURITY_STANDARD]: {
|
[HCI_SETTING.CLUSTER_POD_SECURITY_STANDARD]: {
|
||||||
kind: 'json', from: 'import', canReset: true, featureFlag: 'clusterPodSecurityStandardSetting'
|
kind: 'json', from: 'import', canReset: true, featureFlag: 'clusterPodSecurityStandardSetting'
|
||||||
},
|
|
||||||
[HCI_SETTING.MAINTENANCE_MODE_DRAIN_TIMEOUT]: {
|
|
||||||
kind: 'number', canReset: true, featureFlag: 'maintenanceModeDrainTimeoutSetting'
|
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -15,13 +15,6 @@ export const VOLUME_MODE = {
|
|||||||
FILE_SYSTEM: 'Filesystem'
|
FILE_SYSTEM: 'Filesystem'
|
||||||
};
|
};
|
||||||
|
|
||||||
export const ACCESS_MODE = {
|
|
||||||
READ_WRITE_MANY: 'ReadWriteMany',
|
|
||||||
READ_WRITE_ONCE: 'ReadWriteOnce',
|
|
||||||
READ_ONLY_MANY: 'ReadOnlyMany',
|
|
||||||
READ_WRITE_ONCE_POD: 'ReadWriteOncePod',
|
|
||||||
};
|
|
||||||
|
|
||||||
export const NETWORK_PROTOCOL = {
|
export const NETWORK_PROTOCOL = {
|
||||||
IPv4: 'IPv4',
|
IPv4: 'IPv4',
|
||||||
IPv6: 'IPv6',
|
IPv6: 'IPv6',
|
||||||
|
|||||||
@@ -15,7 +15,6 @@ import OverviewKeypairs from '../kubevirt.io.virtualmachine/VirtualMachineTabs/V
|
|||||||
import Volume from '../../edit/kubevirt.io.virtualmachine/VirtualMachineVolume';
|
import Volume from '../../edit/kubevirt.io.virtualmachine/VirtualMachineVolume';
|
||||||
import Network from '../../edit/kubevirt.io.virtualmachine/VirtualMachineNetwork';
|
import Network from '../../edit/kubevirt.io.virtualmachine/VirtualMachineNetwork';
|
||||||
import CloudConfig from '../../edit/kubevirt.io.virtualmachine/VirtualMachineCloudConfig';
|
import CloudConfig from '../../edit/kubevirt.io.virtualmachine/VirtualMachineCloudConfig';
|
||||||
import { getBootDevices } from '../../utils/vm';
|
|
||||||
const UNDEFINED = 'n/a';
|
const UNDEFINED = 'n/a';
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
@@ -75,8 +74,18 @@ export default {
|
|||||||
return image?.spec?.displayName || '-';
|
return image?.spec?.displayName || '-';
|
||||||
},
|
},
|
||||||
|
|
||||||
bootDevices() {
|
disks() {
|
||||||
return getBootDevices(this?.spec?.template?.spec?.domain?.devices);
|
const disks = this?.spec?.template?.spec?.domain?.devices?.disks || [];
|
||||||
|
|
||||||
|
return disks.filter((disk) => {
|
||||||
|
return !!disk.bootOrder;
|
||||||
|
}).sort((a, b) => {
|
||||||
|
if (a.bootOrder < b.bootOrder) {
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
|
||||||
|
return 1;
|
||||||
|
});
|
||||||
},
|
},
|
||||||
|
|
||||||
cdroms() {
|
cdroms() {
|
||||||
@@ -92,10 +101,8 @@ export default {
|
|||||||
getDeviceType(o) {
|
getDeviceType(o) {
|
||||||
if (o.disk) {
|
if (o.disk) {
|
||||||
return 'Disk';
|
return 'Disk';
|
||||||
} else if (o.cdrom) {
|
|
||||||
return 'CD-ROM';
|
|
||||||
} else {
|
} else {
|
||||||
return 'Network';
|
return 'CD-ROM';
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
isEmpty(o) {
|
isEmpty(o) {
|
||||||
@@ -177,10 +184,10 @@ export default {
|
|||||||
<div>
|
<div>
|
||||||
<ul>
|
<ul>
|
||||||
<li
|
<li
|
||||||
v-for="(device, i) in bootDevices"
|
v-for="(disk, i) in disks"
|
||||||
:key="i"
|
:key="i"
|
||||||
>
|
>
|
||||||
{{ device.bootOrder }}. {{ device.name }} ({{ getDeviceType(device) }})
|
{{ disk.bootOrder }}. {{ disk.name }} ({{ getDeviceType(disk) }})
|
||||||
</li>
|
</li>
|
||||||
</ul>
|
</ul>
|
||||||
</div>
|
</div>
|
||||||
@@ -226,7 +233,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Network
|
<Network
|
||||||
v-model:value="networkRows"
|
v-model:value="networkRows"
|
||||||
:network-boot-first="networkBootFirst"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
/>
|
/>
|
||||||
</Tab>
|
</Tab>
|
||||||
|
|||||||
@@ -15,7 +15,6 @@ import OverviewKeypairs from '../kubevirt.io.virtualmachine/VirtualMachineTabs/V
|
|||||||
import Volume from '../../edit/kubevirt.io.virtualmachine/VirtualMachineVolume';
|
import Volume from '../../edit/kubevirt.io.virtualmachine/VirtualMachineVolume';
|
||||||
import Network from '../../edit/kubevirt.io.virtualmachine/VirtualMachineNetwork';
|
import Network from '../../edit/kubevirt.io.virtualmachine/VirtualMachineNetwork';
|
||||||
import CloudConfig from '../../edit/kubevirt.io.virtualmachine/VirtualMachineCloudConfig';
|
import CloudConfig from '../../edit/kubevirt.io.virtualmachine/VirtualMachineCloudConfig';
|
||||||
import { getBootDevices } from '../../utils/vm';
|
|
||||||
const UNDEFINED = 'n/a';
|
const UNDEFINED = 'n/a';
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
@@ -75,8 +74,18 @@ export default {
|
|||||||
return image?.spec?.displayName || '-';
|
return image?.spec?.displayName || '-';
|
||||||
},
|
},
|
||||||
|
|
||||||
bootDevices() {
|
disks() {
|
||||||
return getBootDevices(this?.spec?.template?.spec?.domain?.devices);
|
const disks = this?.spec?.template?.spec?.domain?.devices?.disks || [];
|
||||||
|
|
||||||
|
return disks.filter((disk) => {
|
||||||
|
return !!disk.bootOrder;
|
||||||
|
}).sort((a, b) => {
|
||||||
|
if (a.bootOrder < b.bootOrder) {
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
|
||||||
|
return 1;
|
||||||
|
});
|
||||||
},
|
},
|
||||||
|
|
||||||
cdroms() {
|
cdroms() {
|
||||||
@@ -92,10 +101,8 @@ export default {
|
|||||||
getDeviceType(o) {
|
getDeviceType(o) {
|
||||||
if (o.disk) {
|
if (o.disk) {
|
||||||
return 'Disk';
|
return 'Disk';
|
||||||
} else if (o.cdrom) {
|
|
||||||
return 'CD-ROM';
|
|
||||||
} else {
|
} else {
|
||||||
return 'Network';
|
return 'CD-ROM';
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
isEmpty(o) {
|
isEmpty(o) {
|
||||||
@@ -177,10 +184,10 @@ export default {
|
|||||||
<div>
|
<div>
|
||||||
<ul>
|
<ul>
|
||||||
<li
|
<li
|
||||||
v-for="(device, i) in bootDevices"
|
v-for="(disk, i) in disks"
|
||||||
:key="i"
|
:key="i"
|
||||||
>
|
>
|
||||||
{{ device.bootOrder }}. {{ device.name }} ({{ getDeviceType(device) }})
|
{{ disk.bootOrder }}. {{ disk.name }} ({{ getDeviceType(disk) }})
|
||||||
</li>
|
</li>
|
||||||
</ul>
|
</ul>
|
||||||
</div>
|
</div>
|
||||||
@@ -227,7 +234,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Network
|
<Network
|
||||||
v-model:value="networkRows"
|
v-model:value="networkRows"
|
||||||
:network-boot-first="networkBootFirst"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
/>
|
/>
|
||||||
</Tab>
|
</Tab>
|
||||||
|
|||||||
+16
-9
@@ -6,7 +6,6 @@ import HarvesterIpAddress from '../../../formatters/HarvesterIpAddress';
|
|||||||
import VMConsoleBar from '../../../components/VMConsoleBar';
|
import VMConsoleBar from '../../../components/VMConsoleBar';
|
||||||
import { HCI } from '../../../types';
|
import { HCI } from '../../../types';
|
||||||
import { getVmCPUMemoryValues } from '../../../utils/cpuMemory';
|
import { getVmCPUMemoryValues } from '../../../utils/cpuMemory';
|
||||||
import { getBootDevices } from '../../../utils/vm';
|
|
||||||
|
|
||||||
const UNDEFINED = 'n/a';
|
const UNDEFINED = 'n/a';
|
||||||
|
|
||||||
@@ -70,8 +69,18 @@ export default {
|
|||||||
return image?.spec?.displayName || 'N/A';
|
return image?.spec?.displayName || 'N/A';
|
||||||
},
|
},
|
||||||
|
|
||||||
bootDevices() {
|
disks() {
|
||||||
return getBootDevices(this.value?.spec?.template?.spec?.domain?.devices);
|
const disks = this.value?.spec?.template?.spec?.domain?.devices?.disks || [];
|
||||||
|
|
||||||
|
return disks.filter((disk) => {
|
||||||
|
return !!disk.bootOrder;
|
||||||
|
}).sort((a, b) => {
|
||||||
|
if (a.bootOrder < b.bootOrder) {
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
|
||||||
|
return 1;
|
||||||
|
});
|
||||||
},
|
},
|
||||||
|
|
||||||
cdroms() {
|
cdroms() {
|
||||||
@@ -113,10 +122,8 @@ export default {
|
|||||||
getDeviceType(o) {
|
getDeviceType(o) {
|
||||||
if (o.disk) {
|
if (o.disk) {
|
||||||
return 'Disk';
|
return 'Disk';
|
||||||
} else if (o.cdrom) {
|
|
||||||
return 'CD-ROM';
|
|
||||||
} else {
|
} else {
|
||||||
return 'Network';
|
return 'CD-ROM';
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
isEmpty(o) {
|
isEmpty(o) {
|
||||||
@@ -212,16 +219,16 @@ export default {
|
|||||||
<div class="col span-6">
|
<div class="col span-6">
|
||||||
<InputOrDisplay
|
<InputOrDisplay
|
||||||
:name="t('harvester.virtualMachine.detail.details.bootOrder')"
|
:name="t('harvester.virtualMachine.detail.details.bootOrder')"
|
||||||
:value="bootDevices"
|
:value="disks"
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
>
|
>
|
||||||
<template #value>
|
<template #value>
|
||||||
<ul>
|
<ul>
|
||||||
<li
|
<li
|
||||||
v-for="(device, i) in bootDevices"
|
v-for="(disk, i) in disks"
|
||||||
:key="i"
|
:key="i"
|
||||||
>
|
>
|
||||||
{{ device.bootOrder }}. {{ device.name }} ({{ getDeviceType(device) }})
|
{{ disk.bootOrder }}. {{ disk.name }} ({{ getDeviceType(disk) }})
|
||||||
</li>
|
</li>
|
||||||
</ul>
|
</ul>
|
||||||
</template>
|
</template>
|
||||||
|
|||||||
@@ -214,15 +214,6 @@ export default {
|
|||||||
|
|
||||||
this['diskRows'] = diskRows;
|
this['diskRows'] = diskRows;
|
||||||
this['networkRows'] = this.getNetworkRows(neu, { fromTemplate: false, init: false });
|
this['networkRows'] = this.getNetworkRows(neu, { fromTemplate: false, init: false });
|
||||||
this['networkBootFirst'] = this.isNetworkBootFirst(neu.spec);
|
|
||||||
|
|
||||||
// getInitConfig() seeds these on created(); refresh them here too so the
|
|
||||||
// VM-wide performance panel does not go stale when the spec changes.
|
|
||||||
const domain = neu?.spec?.template?.spec?.domain;
|
|
||||||
|
|
||||||
this['blockMultiQueue'] = domain?.devices?.blockMultiQueue || false;
|
|
||||||
this['ioThreadsPolicy'] = domain?.ioThreadsPolicy || '';
|
|
||||||
this['ioThreadCount'] = domain?.ioThreads?.supplementalPoolThreadCount || 2;
|
|
||||||
},
|
},
|
||||||
deep: true
|
deep: true
|
||||||
}
|
}
|
||||||
@@ -263,9 +254,6 @@ export default {
|
|||||||
:namespace="value.metadata.namespace"
|
:namespace="value.metadata.namespace"
|
||||||
:vm="value"
|
:vm="value"
|
||||||
:resource-type="value.type"
|
:resource-type="value.type"
|
||||||
:block-multi-queue="blockMultiQueue"
|
|
||||||
:io-threads-policy="ioThreadsPolicy"
|
|
||||||
:io-thread-count="ioThreadCount"
|
|
||||||
/>
|
/>
|
||||||
</Tab>
|
</Tab>
|
||||||
|
|
||||||
@@ -277,7 +265,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Network
|
<Network
|
||||||
v-model:value="networkRows"
|
v-model:value="networkRows"
|
||||||
:network-boot-first="networkBootFirst"
|
|
||||||
mode="view"
|
mode="view"
|
||||||
:vm="value"
|
:vm="value"
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
<script>
|
<script>
|
||||||
import { VOLUME_MODE, ACCESS_MODE } from '@pkg/harvester/config/types';
|
import { VOLUME_MODE } from '@pkg/harvester/config/types';
|
||||||
import { HCI as HCI_ANNOTATIONS } from '@pkg/harvester/config/labels-annotations';
|
import { HCI as HCI_ANNOTATIONS } from '@pkg/harvester/config/labels-annotations';
|
||||||
import ArrayList from '@shell/components/form/ArrayList';
|
import ArrayList from '@shell/components/form/ArrayList';
|
||||||
import { Checkbox } from '@components/Form/Checkbox';
|
import { Checkbox } from '@components/Form/Checkbox';
|
||||||
@@ -10,10 +10,6 @@ import { HCI_SETTING } from '../../config/settings';
|
|||||||
import { allHash } from '@shell/utils/promise';
|
import { allHash } from '@shell/utils/promise';
|
||||||
import { _EDIT, _CREATE } from '@shell/config/query-params';
|
import { _EDIT, _CREATE } from '@shell/config/query-params';
|
||||||
|
|
||||||
const {
|
|
||||||
READ_WRITE_ONCE, READ_ONLY_MANY, READ_WRITE_MANY, READ_WRITE_ONCE_POD
|
|
||||||
} = ACCESS_MODE;
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'CDISettings',
|
name: 'CDISettings',
|
||||||
|
|
||||||
@@ -94,10 +90,10 @@ export default {
|
|||||||
|
|
||||||
accessModeOptions() {
|
accessModeOptions() {
|
||||||
return [
|
return [
|
||||||
{ label: READ_WRITE_ONCE, value: READ_WRITE_ONCE },
|
{ label: 'ReadWriteOnce', value: 'ReadWriteOnce' },
|
||||||
{ label: READ_ONLY_MANY, value: READ_ONLY_MANY },
|
{ label: 'ReadOnlyMany', value: 'ReadOnlyMany' },
|
||||||
{ label: READ_WRITE_MANY, value: READ_WRITE_MANY },
|
{ label: 'ReadWriteMany', value: 'ReadWriteMany' },
|
||||||
{ label: READ_WRITE_ONCE_POD, value: READ_WRITE_ONCE_POD },
|
{ label: 'ReadWriteOncePod', value: 'ReadWriteOncePod' },
|
||||||
];
|
];
|
||||||
},
|
},
|
||||||
|
|
||||||
|
|||||||
@@ -308,9 +308,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Volume
|
<Volume
|
||||||
v-model:value="diskRows"
|
v-model:value="diskRows"
|
||||||
v-model:block-multi-queue="blockMultiQueue"
|
|
||||||
v-model:io-threads-policy="ioThreadsPolicy"
|
|
||||||
v-model:io-thread-count="ioThreadCount"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
:namespace="value.metadata.namespace"
|
:namespace="value.metadata.namespace"
|
||||||
:existing-volume-disabled="true"
|
:existing-volume-disabled="true"
|
||||||
@@ -324,7 +321,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Network
|
<Network
|
||||||
v-model:value="networkRows"
|
v-model:value="networkRows"
|
||||||
v-model:network-boot-first="networkBootFirst"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
/>
|
/>
|
||||||
</Tab>
|
</Tab>
|
||||||
|
|||||||
@@ -8,7 +8,6 @@ import LabeledSelect from '@shell/components/form/LabeledSelect';
|
|||||||
import { LabeledInput } from '@components/Form/LabeledInput';
|
import { LabeledInput } from '@components/Form/LabeledInput';
|
||||||
import NameNsDescription from '@shell/components/form/NameNsDescription';
|
import NameNsDescription from '@shell/components/form/NameNsDescription';
|
||||||
import Conditions from '@shell/components/form/Conditions';
|
import Conditions from '@shell/components/form/Conditions';
|
||||||
import DiskPerformanceOptions from './kubevirt.io.virtualmachine/VirtualMachineVolume/DiskPerformanceOptions';
|
|
||||||
import { Banner } from '@components/Banner';
|
import { Banner } from '@components/Banner';
|
||||||
import { Checkbox } from '@components/Form/Checkbox';
|
import { Checkbox } from '@components/Form/Checkbox';
|
||||||
import jsyaml from 'js-yaml';
|
import jsyaml from 'js-yaml';
|
||||||
@@ -27,11 +26,9 @@ import { HCI, VOLUME_SNAPSHOT } from '../types';
|
|||||||
import { LVM_DRIVER } from '../models/harvester/storage.k8s.io.storageclass';
|
import { LVM_DRIVER } from '../models/harvester/storage.k8s.io.storageclass';
|
||||||
import { DATA_ENGINE_V2 } from '../models/harvester/persistentvolumeclaim';
|
import { DATA_ENGINE_V2 } from '../models/harvester/persistentvolumeclaim';
|
||||||
import { GIBIBYTE } from '../utils/unit';
|
import { GIBIBYTE } from '../utils/unit';
|
||||||
import { VOLUME_MODE, ACCESS_MODE } from '@pkg/harvester/config/types';
|
import { VOLUME_MODE } from '@pkg/harvester/config/types';
|
||||||
import { isInternalStorageClass } from '../utils/storage-class';
|
import { isInternalStorageClass } from '../utils/storage-class';
|
||||||
|
|
||||||
const { READ_WRITE_MANY, READ_WRITE_ONCE, READ_ONLY_MANY } = ACCESS_MODE;
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'HarvesterVolume',
|
name: 'HarvesterVolume',
|
||||||
|
|
||||||
@@ -48,8 +45,7 @@ export default {
|
|||||||
LabeledSelect,
|
LabeledSelect,
|
||||||
LabeledInput,
|
LabeledInput,
|
||||||
NameNsDescription,
|
NameNsDescription,
|
||||||
Conditions,
|
Conditions
|
||||||
DiskPerformanceOptions
|
|
||||||
},
|
},
|
||||||
|
|
||||||
mixins: [CreateEditView],
|
mixins: [CreateEditView],
|
||||||
@@ -87,7 +83,7 @@ export default {
|
|||||||
if (this.mode === _CREATE) {
|
if (this.mode === _CREATE) {
|
||||||
// default volumeMode to Block
|
// default volumeMode to Block
|
||||||
this.value.spec.volumeMode = VOLUME_MODE.BLOCK;
|
this.value.spec.volumeMode = VOLUME_MODE.BLOCK;
|
||||||
this.value.spec.accessModes = [READ_WRITE_MANY];
|
this.value.spec.accessModes = ['ReadWriteMany'];
|
||||||
}
|
}
|
||||||
|
|
||||||
const storage = this.value?.spec?.resources?.requests?.storage || null;
|
const storage = this.value?.spec?.resources?.requests?.storage || null;
|
||||||
@@ -102,15 +98,7 @@ export default {
|
|||||||
createWithDataVolume: false,
|
createWithDataVolume: false,
|
||||||
snapshots: [],
|
snapshots: [],
|
||||||
images: [],
|
images: [],
|
||||||
GIBIBYTE,
|
GIBIBYTE
|
||||||
// Default KubeVirt high-performance disk profile, stored as annotations and
|
|
||||||
// applied when this volume is later attached to a VM as a disk.
|
|
||||||
perf: {
|
|
||||||
cache: get(this.value, `metadata.annotations."${ HCI_ANNOTATIONS.DISK_CACHE_MODE }"`) || '',
|
|
||||||
io: get(this.value, `metadata.annotations."${ HCI_ANNOTATIONS.DISK_IO_MODE }"`) || '',
|
|
||||||
dedicatedIOThread: get(this.value, `metadata.annotations."${ HCI_ANNOTATIONS.DISK_DEDICATED_IOTHREAD }"`) === 'true',
|
|
||||||
volumeMode: this.value?.spec?.volumeMode,
|
|
||||||
},
|
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -172,7 +160,7 @@ export default {
|
|||||||
},
|
},
|
||||||
|
|
||||||
accessModeOptions() {
|
accessModeOptions() {
|
||||||
return [READ_WRITE_ONCE, READ_WRITE_MANY, READ_ONLY_MANY];
|
return ['ReadWriteOnce', 'ReadWriteMany', 'ReadOnlyMany'];
|
||||||
},
|
},
|
||||||
|
|
||||||
imageOption() {
|
imageOption() {
|
||||||
@@ -342,7 +330,6 @@ export default {
|
|||||||
}
|
}
|
||||||
},
|
},
|
||||||
'value.spec.volumeMode'(neu) {
|
'value.spec.volumeMode'(neu) {
|
||||||
this.perf.volumeMode = neu;
|
|
||||||
if (neu === VOLUME_MODE.FILE_SYSTEM) {
|
if (neu === VOLUME_MODE.FILE_SYSTEM) {
|
||||||
this.setVolumeForVmAnnotation();
|
this.setVolumeForVmAnnotation();
|
||||||
} else if (neu === VOLUME_MODE.BLOCK ) {
|
} else if (neu === VOLUME_MODE.BLOCK ) {
|
||||||
@@ -368,7 +355,7 @@ export default {
|
|||||||
|
|
||||||
getAccessMode() {
|
getAccessMode() {
|
||||||
if (!this.longhornV2LVMSupport) {
|
if (!this.longhornV2LVMSupport) {
|
||||||
return [READ_WRITE_MANY];
|
return ['ReadWriteMany'];
|
||||||
}
|
}
|
||||||
|
|
||||||
if (this.value?.spec?.accessModes && this.value?.spec?.accessModes?.length > 0) {
|
if (this.value?.spec?.accessModes && this.value?.spec?.accessModes?.length > 0) {
|
||||||
@@ -384,7 +371,7 @@ export default {
|
|||||||
readWriteOnce = storageClass.provisioner === LVM_DRIVER || (!this.value.thirdPartyStorageFeatureEnabled && storageClass.parameters?.dataEngine === DATA_ENGINE_V2);
|
readWriteOnce = storageClass.provisioner === LVM_DRIVER || (!this.value.thirdPartyStorageFeatureEnabled && storageClass.parameters?.dataEngine === DATA_ENGINE_V2);
|
||||||
}
|
}
|
||||||
|
|
||||||
return readWriteOnce ? [READ_WRITE_ONCE] : [READ_WRITE_MANY];
|
return readWriteOnce ? ['ReadWriteOnce'] : ['ReadWriteMany'];
|
||||||
},
|
},
|
||||||
buildDataVolumeObj() {
|
buildDataVolumeObj() {
|
||||||
const storage = {
|
const storage = {
|
||||||
@@ -457,23 +444,6 @@ export default {
|
|||||||
imageAnnotations = { ...this.value.metadata.annotations };
|
imageAnnotations = { ...this.value.metadata.annotations };
|
||||||
}
|
}
|
||||||
|
|
||||||
// Persist the default high-performance disk profile as annotations.
|
|
||||||
if (this.perf.cache) {
|
|
||||||
imageAnnotations[HCI_ANNOTATIONS.DISK_CACHE_MODE] = this.perf.cache;
|
|
||||||
} else {
|
|
||||||
delete imageAnnotations[HCI_ANNOTATIONS.DISK_CACHE_MODE];
|
|
||||||
}
|
|
||||||
if (this.perf.io) {
|
|
||||||
imageAnnotations[HCI_ANNOTATIONS.DISK_IO_MODE] = this.perf.io;
|
|
||||||
} else {
|
|
||||||
delete imageAnnotations[HCI_ANNOTATIONS.DISK_IO_MODE];
|
|
||||||
}
|
|
||||||
if (this.perf.dedicatedIOThread) {
|
|
||||||
imageAnnotations[HCI_ANNOTATIONS.DISK_DEDICATED_IOTHREAD] = 'true';
|
|
||||||
} else {
|
|
||||||
delete imageAnnotations[HCI_ANNOTATIONS.DISK_DEDICATED_IOTHREAD];
|
|
||||||
}
|
|
||||||
|
|
||||||
const spec = {
|
const spec = {
|
||||||
...this.value.spec,
|
...this.value.spec,
|
||||||
resources: { requests: { storage: this.storage } },
|
resources: { requests: { storage: this.storage } },
|
||||||
@@ -638,16 +608,6 @@ export default {
|
|||||||
class="mb-20"
|
class="mb-20"
|
||||||
@update:value="update"
|
@update:value="update"
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<Banner
|
|
||||||
color="info"
|
|
||||||
:label="t('harvester.volume.performance.pvcTip')"
|
|
||||||
/>
|
|
||||||
<DiskPerformanceOptions
|
|
||||||
:value="perf"
|
|
||||||
:mode="mode"
|
|
||||||
@update="update"
|
|
||||||
/>
|
|
||||||
</Tab>
|
</Tab>
|
||||||
<Tab
|
<Tab
|
||||||
v-if="!isCreate"
|
v-if="!isCreate"
|
||||||
|
|||||||
@@ -2,7 +2,6 @@
|
|||||||
import InputOrDisplay from '@shell/components/InputOrDisplay';
|
import InputOrDisplay from '@shell/components/InputOrDisplay';
|
||||||
import { LabeledInput } from '@components/Form/LabeledInput';
|
import { LabeledInput } from '@components/Form/LabeledInput';
|
||||||
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
||||||
import { Checkbox } from '@components/Form/Checkbox';
|
|
||||||
|
|
||||||
import { clone } from '@shell/utils/object';
|
import { clone } from '@shell/utils/object';
|
||||||
import { _CREATE, _VIEW } from '@shell/config/query-params';
|
import { _CREATE, _VIEW } from '@shell/config/query-params';
|
||||||
@@ -34,7 +33,7 @@ export default {
|
|||||||
emits: ['update'],
|
emits: ['update'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
LabeledInput, LabeledSelect, InputOrDisplay, Checkbox
|
LabeledInput, LabeledSelect, InputOrDisplay
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -170,7 +169,6 @@ export default {
|
|||||||
this.value.isPod = true;
|
this.value.isPod = true;
|
||||||
this.value.macAddress = '';
|
this.value.macAddress = '';
|
||||||
this.value.staticIp = '';
|
this.value.staticIp = '';
|
||||||
this.value.networkBoot = false;
|
|
||||||
} else {
|
} else {
|
||||||
this.value.isPod = false;
|
this.value.isPod = false;
|
||||||
}
|
}
|
||||||
@@ -287,22 +285,6 @@ export default {
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div
|
|
||||||
v-if="!isMasquerade"
|
|
||||||
data-testid="input-hen-networkBoot"
|
|
||||||
class="row mb-20"
|
|
||||||
>
|
|
||||||
<div class="col span-12">
|
|
||||||
<Checkbox
|
|
||||||
v-model:value="value.networkBoot"
|
|
||||||
:label="t('harvester.virtualMachine.network.networkBoot.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.network.networkBoot.tip')"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="update"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div v-if="!isMasquerade && isSingle">
|
<div v-if="!isMasquerade && isSingle">
|
||||||
<div class="row mb-20">
|
<div class="row mb-20">
|
||||||
<a
|
<a
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
<script>
|
<script>
|
||||||
import InfoBox from '@shell/components/InfoBox';
|
import InfoBox from '@shell/components/InfoBox';
|
||||||
import { RadioGroup } from '@components/Form/Radio';
|
|
||||||
import { NETWORK_ATTACHMENT } from '@shell/config/types';
|
import { NETWORK_ATTACHMENT } from '@shell/config/types';
|
||||||
import { sortBy } from '@shell/utils/sort';
|
import { sortBy } from '@shell/utils/sort';
|
||||||
import { clone } from '@shell/utils/object';
|
import { clone } from '@shell/utils/object';
|
||||||
@@ -11,11 +10,7 @@ import { HCI as HCI_ANNOTATIONS } from '../../../config/labels-annotations';
|
|||||||
import Base from './base';
|
import Base from './base';
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
components: {
|
components: { InfoBox, Base },
|
||||||
InfoBox, Base, RadioGroup
|
|
||||||
},
|
|
||||||
|
|
||||||
emits: ['update:value', 'update:networkBootFirst'],
|
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
vm: {
|
vm: {
|
||||||
@@ -40,11 +35,6 @@ export default {
|
|||||||
isSingle: {
|
isSingle: {
|
||||||
type: Boolean,
|
type: Boolean,
|
||||||
default: true
|
default: true
|
||||||
},
|
|
||||||
|
|
||||||
networkBootFirst: {
|
|
||||||
type: Boolean,
|
|
||||||
default: true
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -92,20 +82,6 @@ export default {
|
|||||||
|
|
||||||
vmState() {
|
vmState() {
|
||||||
return this.vm?.stateDisplay;
|
return this.vm?.stateDisplay;
|
||||||
},
|
|
||||||
|
|
||||||
hasNetworkBoot() {
|
|
||||||
return this.rows.some((R) => R.networkBoot);
|
|
||||||
},
|
|
||||||
|
|
||||||
networkBootOrderOptions() {
|
|
||||||
return [{
|
|
||||||
label: this.t('harvester.virtualMachine.network.networkBoot.first'),
|
|
||||||
value: true
|
|
||||||
}, {
|
|
||||||
label: this.t('harvester.virtualMachine.network.networkBoot.last'),
|
|
||||||
value: false
|
|
||||||
}];
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -242,22 +218,6 @@ export default {
|
|||||||
/>
|
/>
|
||||||
</InfoBox>
|
</InfoBox>
|
||||||
|
|
||||||
<div
|
|
||||||
v-if="hasNetworkBoot"
|
|
||||||
data-testid="input-hen-networkBootFirst"
|
|
||||||
class="mb-20"
|
|
||||||
>
|
|
||||||
<RadioGroup
|
|
||||||
:value="networkBootFirst"
|
|
||||||
name="networkBootFirst"
|
|
||||||
:label="t('harvester.virtualMachine.network.networkBoot.order')"
|
|
||||||
:options="networkBootOrderOptions"
|
|
||||||
:mode="mode"
|
|
||||||
:row="true"
|
|
||||||
@update:value="$emit('update:networkBootFirst', $event)"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<button
|
<button
|
||||||
v-if="!isView"
|
v-if="!isView"
|
||||||
type="button"
|
type="button"
|
||||||
|
|||||||
-321
@@ -1,321 +0,0 @@
|
|||||||
<script>
|
|
||||||
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
|
||||||
import { Checkbox } from '@components/Form/Checkbox';
|
|
||||||
import { Banner } from '@components/Banner';
|
|
||||||
import { _VIEW } from '@shell/config/query-params';
|
|
||||||
import { DISK_CACHE_MODE, DISK_IO_MODE, DISK_PERFORMANCE_PROFILE } from '../../../config/harvester-map';
|
|
||||||
|
|
||||||
const { DEFAULT, HIGH, CUSTOM } = DISK_PERFORMANCE_PROFILE;
|
|
||||||
|
|
||||||
export default {
|
|
||||||
name: 'DiskPerformanceOptions',
|
|
||||||
|
|
||||||
components: {
|
|
||||||
LabeledSelect, Checkbox, Banner
|
|
||||||
},
|
|
||||||
|
|
||||||
emits: ['update'],
|
|
||||||
|
|
||||||
props: {
|
|
||||||
// The disk row. This component reads/writes value.cache, value.io,
|
|
||||||
// value.dedicatedIOThread and (for the "High Performance" preset) value.bus.
|
|
||||||
value: {
|
|
||||||
type: Object,
|
|
||||||
default: () => ({})
|
|
||||||
},
|
|
||||||
|
|
||||||
mode: {
|
|
||||||
type: String,
|
|
||||||
default: 'create'
|
|
||||||
},
|
|
||||||
},
|
|
||||||
|
|
||||||
data() {
|
|
||||||
const hasPerf = !!(this.value.cache || this.value.io || this.value.dedicatedIOThread);
|
|
||||||
|
|
||||||
return {
|
|
||||||
DISK_PERFORMANCE_PROFILE,
|
|
||||||
expanded: hasPerf,
|
|
||||||
profile: this.detectProfile(),
|
|
||||||
// Bus the disk used before the "High Performance" preset switched it to
|
|
||||||
// virtio, so returning to "Default" can put it back.
|
|
||||||
busBeforeHighProfile: null,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
|
|
||||||
computed: {
|
|
||||||
isView() {
|
|
||||||
return this.mode === _VIEW;
|
|
||||||
},
|
|
||||||
|
|
||||||
storagePerformanceEnabled() {
|
|
||||||
return this.$store.getters['harvester-common/getFeatureEnabled']('highPerformanceStorage');
|
|
||||||
},
|
|
||||||
|
|
||||||
isCdRom() {
|
|
||||||
return this.value.type === 'cd-rom';
|
|
||||||
},
|
|
||||||
|
|
||||||
isCustom() {
|
|
||||||
return this.profile === CUSTOM;
|
|
||||||
},
|
|
||||||
|
|
||||||
isNativeIo() {
|
|
||||||
return this.value.io === 'native';
|
|
||||||
},
|
|
||||||
|
|
||||||
profileOptions() {
|
|
||||||
return [DEFAULT, HIGH, CUSTOM].map((value) => ({
|
|
||||||
label: this.t(`harvester.virtualMachine.volume.performance.profile.${ value }`),
|
|
||||||
value,
|
|
||||||
}));
|
|
||||||
},
|
|
||||||
|
|
||||||
cacheOptions() {
|
|
||||||
return DISK_CACHE_MODE.map((value) => ({
|
|
||||||
label: this.cacheLabel(value),
|
|
||||||
value,
|
|
||||||
// Native AIO only works with an uncached (O_DIRECT) disk, so while it is
|
|
||||||
// selected the only valid cache option is "none" — disable everything
|
|
||||||
// else, including "Default", to prevent an invalid combination.
|
|
||||||
disabled: this.isNativeIo && value !== 'none',
|
|
||||||
}));
|
|
||||||
},
|
|
||||||
|
|
||||||
ioOptions() {
|
|
||||||
return DISK_IO_MODE.map((value) => ({
|
|
||||||
label: value === '' ? this.t('harvester.virtualMachine.volume.performance.ioMode.default') : this.t(`harvester.virtualMachine.volume.performance.ioMode.${ value }`),
|
|
||||||
value,
|
|
||||||
}));
|
|
||||||
},
|
|
||||||
|
|
||||||
showFilesystemCacheWarning() {
|
|
||||||
return this.value.cache === 'none' && this.value.volumeMode === 'Filesystem';
|
|
||||||
},
|
|
||||||
|
|
||||||
showBusTip() {
|
|
||||||
const hasPerf = !!(this.value.cache || this.value.io || this.value.dedicatedIOThread);
|
|
||||||
|
|
||||||
return hasPerf && this.value.bus && this.value.bus !== 'virtio';
|
|
||||||
},
|
|
||||||
},
|
|
||||||
|
|
||||||
watch: {
|
|
||||||
// Keep the profile selector in sync if the row is repopulated (e.g. editing an existing VM).
|
|
||||||
'value.cache'() {
|
|
||||||
this.profile = this.detectProfile();
|
|
||||||
},
|
|
||||||
'value.io'() {
|
|
||||||
this.profile = this.detectProfile();
|
|
||||||
},
|
|
||||||
'value.dedicatedIOThread'() {
|
|
||||||
this.profile = this.detectProfile();
|
|
||||||
},
|
|
||||||
},
|
|
||||||
|
|
||||||
methods: {
|
|
||||||
detectProfile() {
|
|
||||||
const { cache, io, dedicatedIOThread } = this.value;
|
|
||||||
|
|
||||||
if (!cache && !io && !dedicatedIOThread) {
|
|
||||||
return DEFAULT;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (cache === 'none' && io === 'native' && dedicatedIOThread) {
|
|
||||||
return HIGH;
|
|
||||||
}
|
|
||||||
|
|
||||||
return CUSTOM;
|
|
||||||
},
|
|
||||||
|
|
||||||
cacheLabel(value) {
|
|
||||||
if (value === '') {
|
|
||||||
return this.t('harvester.virtualMachine.volume.performance.cacheMode.default');
|
|
||||||
}
|
|
||||||
|
|
||||||
return this.t(`harvester.virtualMachine.volume.performance.cacheMode.${ value }`);
|
|
||||||
},
|
|
||||||
|
|
||||||
onProfileChange(profile) {
|
|
||||||
const previous = this.profile;
|
|
||||||
|
|
||||||
this.profile = profile;
|
|
||||||
|
|
||||||
if (profile === DEFAULT) {
|
|
||||||
this.value.cache = '';
|
|
||||||
this.value.io = '';
|
|
||||||
this.value.dedicatedIOThread = false;
|
|
||||||
|
|
||||||
// "Default" means no overrides, so also undo the virtio bus that the
|
|
||||||
// "High Performance" preset applied. Skip it if the user has since
|
|
||||||
// picked a different bus themselves — that choice is theirs to keep.
|
|
||||||
if (this.busBeforeHighProfile !== null) {
|
|
||||||
if (this.value.bus === 'virtio') {
|
|
||||||
this.value.bus = this.busBeforeHighProfile;
|
|
||||||
}
|
|
||||||
this.busBeforeHighProfile = null;
|
|
||||||
}
|
|
||||||
} else if (profile === HIGH) {
|
|
||||||
this.value.cache = 'none';
|
|
||||||
this.value.io = 'native';
|
|
||||||
this.value.dedicatedIOThread = true;
|
|
||||||
|
|
||||||
if (previous !== HIGH) {
|
|
||||||
this.busBeforeHighProfile = this.value.bus || '';
|
|
||||||
}
|
|
||||||
this.value.bus = 'virtio';
|
|
||||||
}
|
|
||||||
// CUSTOM keeps whatever is currently set, including the bus.
|
|
||||||
|
|
||||||
this.update();
|
|
||||||
},
|
|
||||||
|
|
||||||
onIoChange(io) {
|
|
||||||
this.value.io = io;
|
|
||||||
// Native AIO requires an uncached disk; force cache to "none" to keep the
|
|
||||||
// combo valid — including when cache is still on its "Default" ('') value,
|
|
||||||
// which libvirt would otherwise reject at domain start.
|
|
||||||
if (io === 'native' && this.value.cache !== 'none') {
|
|
||||||
this.value.cache = 'none';
|
|
||||||
}
|
|
||||||
this.update();
|
|
||||||
},
|
|
||||||
|
|
||||||
update() {
|
|
||||||
this.$emit('update');
|
|
||||||
},
|
|
||||||
},
|
|
||||||
};
|
|
||||||
</script>
|
|
||||||
|
|
||||||
<template>
|
|
||||||
<div
|
|
||||||
v-if="!isCdRom && storagePerformanceEnabled"
|
|
||||||
class="disk-performance"
|
|
||||||
>
|
|
||||||
<button
|
|
||||||
v-if="!isView"
|
|
||||||
type="button"
|
|
||||||
class="btn btn-sm role-link expand-toggle"
|
|
||||||
:aria-expanded="expanded"
|
|
||||||
:aria-label="expanded ? t('harvester.virtualMachine.volume.performance.collapse') : t('harvester.virtualMachine.volume.performance.expand')"
|
|
||||||
@click.prevent="expanded = !expanded"
|
|
||||||
>
|
|
||||||
<i
|
|
||||||
class="icon"
|
|
||||||
:class="expanded ? 'icon-chevron-down' : 'icon-chevron-right'"
|
|
||||||
/>
|
|
||||||
{{ t('harvester.virtualMachine.volume.performance.title') }}
|
|
||||||
</button>
|
|
||||||
|
|
||||||
<div
|
|
||||||
v-if="expanded || isView"
|
|
||||||
class="perf-body mt-10"
|
|
||||||
>
|
|
||||||
<div class="row mb-20">
|
|
||||||
<div
|
|
||||||
class="col span-6"
|
|
||||||
data-testid="input-disk-perf-profile"
|
|
||||||
>
|
|
||||||
<LabeledSelect
|
|
||||||
:value="profile"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.profile.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.performance.profile.tip')"
|
|
||||||
:options="profileOptions"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="onProfileChange"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<Banner
|
|
||||||
v-if="profile === DISK_PERFORMANCE_PROFILE.HIGH"
|
|
||||||
color="info"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.highProfileTip')"
|
|
||||||
/>
|
|
||||||
|
|
||||||
<div
|
|
||||||
v-if="isCustom || isView"
|
|
||||||
class="row mb-20"
|
|
||||||
>
|
|
||||||
<div
|
|
||||||
class="col span-6"
|
|
||||||
data-testid="input-disk-cache"
|
|
||||||
>
|
|
||||||
<LabeledSelect
|
|
||||||
v-model:value="value.cache"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.cacheMode.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.performance.cacheMode.tip')"
|
|
||||||
:options="cacheOptions"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="update"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
<div
|
|
||||||
class="col span-6"
|
|
||||||
data-testid="input-disk-io"
|
|
||||||
>
|
|
||||||
<LabeledSelect
|
|
||||||
:value="value.io"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.ioMode.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.performance.ioMode.tip')"
|
|
||||||
:options="ioOptions"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="onIoChange"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div
|
|
||||||
v-if="isCustom || isView"
|
|
||||||
class="row mb-10"
|
|
||||||
>
|
|
||||||
<div
|
|
||||||
class="col span-12"
|
|
||||||
data-testid="input-disk-dedicated-iothread"
|
|
||||||
>
|
|
||||||
<Checkbox
|
|
||||||
v-model:value="value.dedicatedIOThread"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.dedicatedIOThread.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.performance.dedicatedIOThread.tip')"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="update"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<Banner
|
|
||||||
v-if="isNativeIo"
|
|
||||||
color="info"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.ioMode.nativeRequiresNoCacheTip')"
|
|
||||||
/>
|
|
||||||
<Banner
|
|
||||||
v-if="showFilesystemCacheWarning"
|
|
||||||
color="warning"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.cacheMode.filesystemWarning')"
|
|
||||||
/>
|
|
||||||
<Banner
|
|
||||||
v-if="showBusTip"
|
|
||||||
color="warning"
|
|
||||||
:label="t('harvester.virtualMachine.volume.performance.busTip')"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</template>
|
|
||||||
|
|
||||||
<style lang="scss" scoped>
|
|
||||||
.disk-performance {
|
|
||||||
border-top: 1px solid var(--border);
|
|
||||||
margin-top: 10px;
|
|
||||||
padding-top: 10px;
|
|
||||||
|
|
||||||
.expand-toggle {
|
|
||||||
padding: 0;
|
|
||||||
font-weight: 600;
|
|
||||||
|
|
||||||
.icon {
|
|
||||||
margin-right: 4px;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
</style>
|
|
||||||
-191
@@ -1,191 +0,0 @@
|
|||||||
<script>
|
|
||||||
import InfoBox from '@shell/components/InfoBox';
|
|
||||||
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
|
||||||
import { LabeledInput } from '@components/Form/LabeledInput';
|
|
||||||
import { Checkbox } from '@components/Form/Checkbox';
|
|
||||||
import { Banner } from '@components/Banner';
|
|
||||||
import { _VIEW } from '@shell/config/query-params';
|
|
||||||
import { IO_THREADS_POLICY } from '../../../config/harvester-map';
|
|
||||||
|
|
||||||
export default {
|
|
||||||
name: 'VMPerformanceOptions',
|
|
||||||
|
|
||||||
components: {
|
|
||||||
InfoBox, LabeledSelect, LabeledInput, Checkbox, Banner
|
|
||||||
},
|
|
||||||
|
|
||||||
emits: ['update:blockMultiQueue', 'update:ioThreadsPolicy', 'update:ioThreadCount'],
|
|
||||||
|
|
||||||
props: {
|
|
||||||
blockMultiQueue: {
|
|
||||||
type: Boolean,
|
|
||||||
default: false
|
|
||||||
},
|
|
||||||
|
|
||||||
ioThreadsPolicy: {
|
|
||||||
type: String,
|
|
||||||
default: ''
|
|
||||||
},
|
|
||||||
|
|
||||||
ioThreadCount: {
|
|
||||||
type: Number,
|
|
||||||
default: 2
|
|
||||||
},
|
|
||||||
|
|
||||||
mode: {
|
|
||||||
type: String,
|
|
||||||
default: 'create'
|
|
||||||
},
|
|
||||||
|
|
||||||
// Whether the current disk set contains a virtio disk (VM context only).
|
|
||||||
hasVirtioDisk: {
|
|
||||||
type: Boolean,
|
|
||||||
default: true
|
|
||||||
},
|
|
||||||
|
|
||||||
// Whether any disk requests a dedicated I/O thread (drives the auto-enable hint).
|
|
||||||
hasDedicatedIothread: {
|
|
||||||
type: Boolean,
|
|
||||||
default: false
|
|
||||||
},
|
|
||||||
},
|
|
||||||
|
|
||||||
data() {
|
|
||||||
// These are specialist tuning options, so keep the panel collapsed unless the
|
|
||||||
// VM already has something configured.
|
|
||||||
return { expanded: !!(this.blockMultiQueue || this.ioThreadsPolicy) };
|
|
||||||
},
|
|
||||||
|
|
||||||
computed: {
|
|
||||||
isView() {
|
|
||||||
return this.mode === _VIEW;
|
|
||||||
},
|
|
||||||
|
|
||||||
storagePerformanceEnabled() {
|
|
||||||
return this.$store.getters['harvester-common/getFeatureEnabled']('highPerformanceStorage');
|
|
||||||
},
|
|
||||||
|
|
||||||
ioThreadsPolicyOptions() {
|
|
||||||
return IO_THREADS_POLICY.map((value) => ({
|
|
||||||
label: value === '' ? this.t('harvester.virtualMachine.volume.diskPerformance.ioThreadsPolicy.default') : this.t(`harvester.virtualMachine.volume.diskPerformance.ioThreadsPolicy.${ value }`),
|
|
||||||
value,
|
|
||||||
}));
|
|
||||||
},
|
|
||||||
},
|
|
||||||
|
|
||||||
watch: {
|
|
||||||
// Block Multi-Queue only applies to virtio disks. If the last virtio disk is
|
|
||||||
// removed while it is enabled, clear it so the VM is not left with an invalid
|
|
||||||
// setting the disabled checkbox can no longer surface.
|
|
||||||
hasVirtioDisk(neu) {
|
|
||||||
if (!neu && this.blockMultiQueue) {
|
|
||||||
this.$emit('update:blockMultiQueue', false);
|
|
||||||
}
|
|
||||||
},
|
|
||||||
},
|
|
||||||
};
|
|
||||||
</script>
|
|
||||||
|
|
||||||
<template>
|
|
||||||
<InfoBox
|
|
||||||
v-if="storagePerformanceEnabled && (!isView || blockMultiQueue || !!ioThreadsPolicy)"
|
|
||||||
class="vm-perf mt-10"
|
|
||||||
>
|
|
||||||
<button
|
|
||||||
v-if="!isView"
|
|
||||||
type="button"
|
|
||||||
class="btn btn-sm role-link expand-toggle"
|
|
||||||
:aria-expanded="expanded"
|
|
||||||
:aria-label="expanded ? t('harvester.virtualMachine.volume.diskPerformance.collapse') : t('harvester.virtualMachine.volume.diskPerformance.expand')"
|
|
||||||
@click.prevent="expanded = !expanded"
|
|
||||||
>
|
|
||||||
<i
|
|
||||||
class="icon"
|
|
||||||
:class="expanded ? 'icon-chevron-down' : 'icon-chevron-right'"
|
|
||||||
/>
|
|
||||||
{{ t('harvester.virtualMachine.volume.diskPerformance.title') }}
|
|
||||||
</button>
|
|
||||||
<h3
|
|
||||||
v-else
|
|
||||||
class="mb-5"
|
|
||||||
>
|
|
||||||
{{ t('harvester.virtualMachine.volume.diskPerformance.title') }}
|
|
||||||
</h3>
|
|
||||||
|
|
||||||
<template v-if="expanded || isView">
|
|
||||||
<p class="text-muted mb-15 mt-10">
|
|
||||||
{{ t('harvester.virtualMachine.volume.diskPerformance.description') }}
|
|
||||||
</p>
|
|
||||||
|
|
||||||
<div class="row mb-10">
|
|
||||||
<div
|
|
||||||
class="col span-12"
|
|
||||||
data-testid="input-vm-block-multi-queue"
|
|
||||||
>
|
|
||||||
<Checkbox
|
|
||||||
:value="blockMultiQueue"
|
|
||||||
:label="t('harvester.virtualMachine.volume.diskPerformance.blockMultiQueue.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.diskPerformance.blockMultiQueue.tip')"
|
|
||||||
:mode="mode"
|
|
||||||
:disabled="!hasVirtioDisk"
|
|
||||||
@update:value="$emit('update:blockMultiQueue', $event)"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<Banner
|
|
||||||
v-if="!hasVirtioDisk && !isView"
|
|
||||||
color="info"
|
|
||||||
:label="t('harvester.virtualMachine.volume.diskPerformance.blockMultiQueue.noVirtioTip')"
|
|
||||||
/>
|
|
||||||
|
|
||||||
<div class="row mb-10">
|
|
||||||
<div
|
|
||||||
class="col span-6"
|
|
||||||
data-testid="input-vm-iothreads-policy"
|
|
||||||
>
|
|
||||||
<LabeledSelect
|
|
||||||
:value="ioThreadsPolicy"
|
|
||||||
:label="t('harvester.virtualMachine.volume.diskPerformance.ioThreadsPolicy.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.diskPerformance.ioThreadsPolicy.tip')"
|
|
||||||
:options="ioThreadsPolicyOptions"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="$emit('update:ioThreadsPolicy', $event)"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
<div
|
|
||||||
v-if="ioThreadsPolicy === 'supplementalPool'"
|
|
||||||
class="col span-6"
|
|
||||||
data-testid="input-vm-iothread-count"
|
|
||||||
>
|
|
||||||
<LabeledInput
|
|
||||||
type="number"
|
|
||||||
min="1"
|
|
||||||
:value="ioThreadCount"
|
|
||||||
:label="t('harvester.virtualMachine.volume.diskPerformance.ioThreadCount.label')"
|
|
||||||
:tooltip="t('harvester.virtualMachine.volume.diskPerformance.ioThreadCount.tip')"
|
|
||||||
:mode="mode"
|
|
||||||
@update:value="$emit('update:ioThreadCount', Number($event))"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<Banner
|
|
||||||
v-if="hasDedicatedIothread && !ioThreadsPolicy"
|
|
||||||
color="info"
|
|
||||||
:label="t('harvester.virtualMachine.volume.diskPerformance.ioThreadsPolicy.autoEnabledTip')"
|
|
||||||
/>
|
|
||||||
</template>
|
|
||||||
</InfoBox>
|
|
||||||
</template>
|
|
||||||
|
|
||||||
<style lang="scss" scoped>
|
|
||||||
.vm-perf {
|
|
||||||
.expand-toggle {
|
|
||||||
padding: 0;
|
|
||||||
font-weight: 600;
|
|
||||||
|
|
||||||
.icon {
|
|
||||||
margin-right: 4px;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
</style>
|
|
||||||
-125
@@ -1,125 +0,0 @@
|
|||||||
import { mount } from '@vue/test-utils';
|
|
||||||
import { _EDIT } from '@shell/config/query-params';
|
|
||||||
import DiskPerformanceOptions from '../DiskPerformanceOptions.vue';
|
|
||||||
|
|
||||||
const mountOptions = (value, { featureEnabled = true } = {}) => ({
|
|
||||||
props: { value, mode: _EDIT },
|
|
||||||
global: {
|
|
||||||
mocks: {
|
|
||||||
$store: {
|
|
||||||
getters: {
|
|
||||||
'harvester-common/getFeatureEnabled': () => featureEnabled,
|
|
||||||
'i18n/t': (key) => key,
|
|
||||||
'i18n/exists': () => true,
|
|
||||||
}
|
|
||||||
},
|
|
||||||
t: (key) => key,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
const hardDisk = (overrides = {}) => ({
|
|
||||||
type: 'disk', bus: 'virtio', cache: '', io: '', dedicatedIOThread: false, ...overrides
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('component: DiskPerformanceOptions', () => {
|
|
||||||
it('is hidden when the highPerformanceStorage feature is disabled', () => {
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(hardDisk(), { featureEnabled: false }));
|
|
||||||
|
|
||||||
expect(wrapper.find('.disk-performance').exists()).toBe(false);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('renders for a hard disk when the feature is enabled', () => {
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(hardDisk()));
|
|
||||||
|
|
||||||
expect(wrapper.find('.disk-performance').exists()).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('applies the High Performance preset and emits update', () => {
|
|
||||||
const value = hardDisk();
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('highPerformance');
|
|
||||||
|
|
||||||
expect(value.cache).toBe('none');
|
|
||||||
expect(value.io).toBe('native');
|
|
||||||
expect(value.dedicatedIOThread).toBe(true);
|
|
||||||
expect(value.bus).toBe('virtio');
|
|
||||||
expect(wrapper.emitted('update')).toHaveLength(1);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('clears all overrides when switching back to Default', () => {
|
|
||||||
const value = hardDisk({
|
|
||||||
cache: 'none', io: 'native', dedicatedIOThread: true
|
|
||||||
});
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('default');
|
|
||||||
|
|
||||||
expect(value.cache).toBe('');
|
|
||||||
expect(value.io).toBe('');
|
|
||||||
expect(value.dedicatedIOThread).toBe(false);
|
|
||||||
expect(wrapper.emitted('update')).toHaveLength(1);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('restores the original bus when leaving High Performance for Default', () => {
|
|
||||||
const value = hardDisk({ bus: 'sata' });
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('highPerformance');
|
|
||||||
expect(value.bus).toBe('virtio');
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('default');
|
|
||||||
expect(value.bus).toBe('sata');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('keeps a bus the user picked themselves after High Performance', () => {
|
|
||||||
const value = hardDisk({ bus: 'sata' });
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('highPerformance');
|
|
||||||
value.bus = 'scsi';
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('default');
|
|
||||||
expect(value.bus).toBe('scsi');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('leaves the bus alone for a disk that never used the High Performance preset', () => {
|
|
||||||
const value = hardDisk({
|
|
||||||
bus: 'sata', cache: 'writeback', io: 'threads'
|
|
||||||
});
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onProfileChange('default');
|
|
||||||
expect(value.bus).toBe('sata');
|
|
||||||
});
|
|
||||||
|
|
||||||
it.each([
|
|
||||||
['a cached state', 'writeback'],
|
|
||||||
['the Default cache', ''],
|
|
||||||
])('forces cache to none when Native I/O is selected from %s', (_label, cache) => {
|
|
||||||
const value = hardDisk({ cache });
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(value));
|
|
||||||
|
|
||||||
wrapper.vm.onIoChange('native');
|
|
||||||
|
|
||||||
expect(value.io).toBe('native');
|
|
||||||
expect(value.cache).toBe('none');
|
|
||||||
expect(wrapper.emitted('update')).toHaveLength(1);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('disables every cache option except none while Native I/O is active', () => {
|
|
||||||
const wrapper = mount(DiskPerformanceOptions, mountOptions(hardDisk({ io: 'native' })));
|
|
||||||
|
|
||||||
const disabledByValue = wrapper.vm.cacheOptions.reduce((acc, opt) => {
|
|
||||||
acc[opt.value] = opt.disabled;
|
|
||||||
|
|
||||||
return acc;
|
|
||||||
}, {});
|
|
||||||
|
|
||||||
expect(disabledByValue['none']).toBe(false);
|
|
||||||
expect(disabledByValue['']).toBe(true);
|
|
||||||
expect(disabledByValue['writeback']).toBe(true);
|
|
||||||
expect(disabledByValue['writethrough']).toBe(true);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@@ -7,27 +7,24 @@ import UnitInput from '@shell/components/form/UnitInput';
|
|||||||
import { LabeledInput } from '@components/Form/LabeledInput';
|
import { LabeledInput } from '@components/Form/LabeledInput';
|
||||||
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
import LabeledSelect from '@shell/components/form/LabeledSelect';
|
||||||
import ModalWithCard from '@shell/components/ModalWithCard';
|
import ModalWithCard from '@shell/components/ModalWithCard';
|
||||||
import VMPerformanceOptions from './VMPerformanceOptions';
|
|
||||||
import { VOLUME_HOTPLUG_ACTION, SOURCE_TYPE } from '../../../config/harvester-map';
|
|
||||||
import { PVC, STORAGE_CLASS } from '@shell/config/types';
|
import { PVC, STORAGE_CLASS } from '@shell/config/types';
|
||||||
import { clone } from '@shell/utils/object';
|
import { clone } from '@shell/utils/object';
|
||||||
import { ucFirst, randomStr } from '@shell/utils/string';
|
import { ucFirst, randomStr } from '@shell/utils/string';
|
||||||
import { removeObject } from '@shell/utils/array';
|
import { removeObject } from '@shell/utils/array';
|
||||||
import { _VIEW, _EDIT, _CREATE } from '@shell/config/query-params';
|
import { _VIEW, _EDIT, _CREATE } from '@shell/config/query-params';
|
||||||
import { PLUGIN_DEVELOPER, DEV } from '@shell/store/prefs';
|
import { PLUGIN_DEVELOPER, DEV } from '@shell/store/prefs';
|
||||||
|
import { VOLUME_HOTPLUG_ACTION, SOURCE_TYPE } from '../../../config/harvester-map';
|
||||||
import { PRODUCT_NAME as HARVESTER_PRODUCT } from '../../../config/harvester';
|
import { PRODUCT_NAME as HARVESTER_PRODUCT } from '../../../config/harvester';
|
||||||
import { HCI } from '../../../types';
|
import { HCI } from '../../../types';
|
||||||
import { VOLUME_MODE, ACCESS_MODE } from '@pkg/harvester/config/types';
|
import { VOLUME_MODE } from '@pkg/harvester/config/types';
|
||||||
import { OFF } from '../../../models/kubevirt.io.virtualmachine';
|
import { OFF } from '../../../models/kubevirt.io.virtualmachine';
|
||||||
import { EMPTY_IMAGE } from '../../../utils/vm';
|
import { EMPTY_IMAGE } from '../../../utils/vm';
|
||||||
|
|
||||||
const { READ_WRITE_MANY } = ACCESS_MODE;
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
emits: ['update:value', 'update:blockMultiQueue', 'update:ioThreadsPolicy', 'update:ioThreadCount'],
|
emits: ['update:value'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
Banner, BadgeStateFormatter, VueDraggableNext, InfoBox, LabeledInput, UnitInput, LabeledSelect, ModalWithCard, VMPerformanceOptions
|
Banner, BadgeStateFormatter, VueDraggableNext, InfoBox, LabeledInput, UnitInput, LabeledSelect, ModalWithCard
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -72,28 +69,12 @@ export default {
|
|||||||
|
|
||||||
customAccessMode: {
|
customAccessMode: {
|
||||||
type: String,
|
type: String,
|
||||||
default: READ_WRITE_MANY
|
default: 'ReadWriteMany'
|
||||||
},
|
},
|
||||||
|
|
||||||
resourceType: {
|
resourceType: {
|
||||||
type: String,
|
type: String,
|
||||||
default: ''
|
default: ''
|
||||||
},
|
|
||||||
|
|
||||||
// KubeVirt high-performance VM-level features
|
|
||||||
blockMultiQueue: {
|
|
||||||
type: Boolean,
|
|
||||||
default: false
|
|
||||||
},
|
|
||||||
|
|
||||||
ioThreadsPolicy: {
|
|
||||||
type: String,
|
|
||||||
default: ''
|
|
||||||
},
|
|
||||||
|
|
||||||
ioThreadCount: {
|
|
||||||
type: Number,
|
|
||||||
default: 2
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -164,14 +145,6 @@ export default {
|
|||||||
isLHV2VolExpansionFeatureEnabled() {
|
isLHV2VolExpansionFeatureEnabled() {
|
||||||
return this.$store.getters['harvester-common/getFeatureEnabled']('lhV2VolExpansion');
|
return this.$store.getters['harvester-common/getFeatureEnabled']('lhV2VolExpansion');
|
||||||
},
|
},
|
||||||
|
|
||||||
hasVirtioDisk() {
|
|
||||||
return this.rows.some((R) => R.type === 'disk' && R.bus === 'virtio');
|
|
||||||
},
|
|
||||||
|
|
||||||
hasDedicatedIOThread() {
|
|
||||||
return this.rows.some((R) => R.dedicatedIOThread);
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
|
|
||||||
watch: {
|
watch: {
|
||||||
@@ -533,18 +506,6 @@ export default {
|
|||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<VMPerformanceOptions
|
|
||||||
:block-multi-queue="blockMultiQueue"
|
|
||||||
:io-threads-policy="ioThreadsPolicy"
|
|
||||||
:io-thread-count="ioThreadCount"
|
|
||||||
:has-virtio-disk="hasVirtioDisk"
|
|
||||||
:has-dedicated-iothread="hasDedicatedIOThread"
|
|
||||||
:mode="mode"
|
|
||||||
@update:block-multi-queue="$emit('update:blockMultiQueue', $event)"
|
|
||||||
@update:io-threads-policy="$emit('update:ioThreadsPolicy', $event)"
|
|
||||||
@update:io-thread-count="$emit('update:ioThreadCount', $event)"
|
|
||||||
/>
|
|
||||||
|
|
||||||
<ModalWithCard
|
<ModalWithCard
|
||||||
v-if="isOpen"
|
v-if="isOpen"
|
||||||
name="deleteTip"
|
name="deleteTip"
|
||||||
|
|||||||
+1
-8
@@ -4,7 +4,6 @@ import LabeledSelect from '@shell/components/form/LabeledSelect';
|
|||||||
import InputOrDisplay from '@shell/components/InputOrDisplay';
|
import InputOrDisplay from '@shell/components/InputOrDisplay';
|
||||||
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
||||||
import { Banner } from '@components/Banner';
|
import { Banner } from '@components/Banner';
|
||||||
import DiskPerformanceOptions from '../DiskPerformanceOptions';
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'HarvesterEditContainer',
|
name: 'HarvesterEditContainer',
|
||||||
@@ -12,7 +11,7 @@ export default {
|
|||||||
emits: ['update'],
|
emits: ['update'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
LabeledInput, LabeledSelect, InputOrDisplay, Banner, DiskPerformanceOptions
|
LabeledInput, LabeledSelect, InputOrDisplay, Banner
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -154,11 +153,5 @@ export default {
|
|||||||
class="mb-20"
|
class="mb-20"
|
||||||
:label="value.volumeBackups.error.message"
|
:label="value.volumeBackups.error.message"
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<DiskPerformanceOptions
|
|
||||||
:value="value"
|
|
||||||
:mode="mode"
|
|
||||||
@update="update"
|
|
||||||
/>
|
|
||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
|
|||||||
+1
-16
@@ -14,7 +14,6 @@ import { VOLUME_MODE } from '@pkg/harvester/config/types';
|
|||||||
import { HCI } from '../../../../types';
|
import { HCI } from '../../../../types';
|
||||||
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
||||||
import { GIBIBYTE } from '../../../../utils/unit';
|
import { GIBIBYTE } from '../../../../utils/unit';
|
||||||
import DiskPerformanceOptions from '../DiskPerformanceOptions';
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'HarvesterEditExisting',
|
name: 'HarvesterEditExisting',
|
||||||
@@ -22,7 +21,7 @@ export default {
|
|||||||
emits: ['update'],
|
emits: ['update'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
UnitInput, LabeledInput, LabeledSelect, InputOrDisplay, LabelValue, Banner, Checkbox, DiskPerformanceOptions
|
UnitInput, LabeledInput, LabeledSelect, InputOrDisplay, LabelValue, Banner, Checkbox
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -173,14 +172,6 @@ export default {
|
|||||||
this.value.storageClassName = pvcResource.spec.storageClassName;
|
this.value.storageClassName = pvcResource.spec.storageClassName;
|
||||||
this.value.volumeMode = pvcResource.spec.volumeMode;
|
this.value.volumeMode = pvcResource.spec.volumeMode;
|
||||||
this.value.shareable = false;
|
this.value.shareable = false;
|
||||||
|
|
||||||
// Adopt the volume's default high-performance profile (if any) as a starting point.
|
|
||||||
const ann = pvcResource.metadata?.annotations || {};
|
|
||||||
|
|
||||||
this.value.cache = ann[HCI_ANNOTATIONS.DISK_CACHE_MODE] || '';
|
|
||||||
this.value.io = ann[HCI_ANNOTATIONS.DISK_IO_MODE] || '';
|
|
||||||
this.value.dedicatedIOThread = ann[HCI_ANNOTATIONS.DISK_DEDICATED_IOTHREAD] === 'true';
|
|
||||||
|
|
||||||
this.update();
|
this.update();
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -388,11 +379,5 @@ export default {
|
|||||||
class="mb-20"
|
class="mb-20"
|
||||||
:label="value.volumeBackups.error.message"
|
:label="value.volumeBackups.error.message"
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<DiskPerformanceOptions
|
|
||||||
:value="value"
|
|
||||||
:mode="mode"
|
|
||||||
@update="update"
|
|
||||||
/>
|
|
||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
|
|||||||
@@ -15,7 +15,6 @@ import LabelValue from '@shell/components/LabelValue';
|
|||||||
import { ucFirst } from '@shell/utils/string';
|
import { ucFirst } from '@shell/utils/string';
|
||||||
import { GIBIBYTE } from '../../../../utils/unit';
|
import { GIBIBYTE } from '../../../../utils/unit';
|
||||||
import { EMPTY_IMAGE } from '../../../../utils/vm';
|
import { EMPTY_IMAGE } from '../../../../utils/vm';
|
||||||
import DiskPerformanceOptions from '../DiskPerformanceOptions';
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'HarvesterEditVMImage',
|
name: 'HarvesterEditVMImage',
|
||||||
@@ -23,7 +22,7 @@ export default {
|
|||||||
emits: ['update'],
|
emits: ['update'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
UnitInput, LabeledInput, LabeledSelect, InputOrDisplay, LabelValue, Banner, DiskPerformanceOptions
|
UnitInput, LabeledInput, LabeledSelect, InputOrDisplay, LabelValue, Banner
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -483,11 +482,5 @@ export default {
|
|||||||
color="error"
|
color="error"
|
||||||
:label="t('harvester.virtualMachine.volume.vmImageVolumeTip', {diskSize: diskSize, imageVirtualSize: imageVirtualSize})"
|
:label="t('harvester.virtualMachine.volume.vmImageVolumeTip', {diskSize: diskSize, imageVirtualSize: imageVirtualSize})"
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<DiskPerformanceOptions
|
|
||||||
:value="value"
|
|
||||||
:mode="mode"
|
|
||||||
@update="update"
|
|
||||||
/>
|
|
||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
|
|||||||
@@ -9,15 +9,12 @@ import { formatSi, parseSi } from '@shell/utils/units';
|
|||||||
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
import { VOLUME_TYPE, InterfaceOption } from '../../../../config/harvester-map';
|
||||||
import { _VIEW } from '@shell/config/query-params';
|
import { _VIEW } from '@shell/config/query-params';
|
||||||
import LabelValue from '@shell/components/LabelValue';
|
import LabelValue from '@shell/components/LabelValue';
|
||||||
import DiskPerformanceOptions from '../DiskPerformanceOptions';
|
|
||||||
import { ucFirst } from '@shell/utils/string';
|
import { ucFirst } from '@shell/utils/string';
|
||||||
import { LVM_DRIVER } from '../../../../models/harvester/storage.k8s.io.storageclass';
|
import { LVM_DRIVER } from '../../../../models/harvester/storage.k8s.io.storageclass';
|
||||||
import { DATA_ENGINE_V2 } from '../../../../models/harvester/persistentvolumeclaim';
|
import { DATA_ENGINE_V2 } from '../../../../models/harvester/persistentvolumeclaim';
|
||||||
import { GIBIBYTE } from '../../../../utils/unit';
|
import { GIBIBYTE } from '../../../../utils/unit';
|
||||||
import { isInternalStorageClass } from '../../../../utils/storage-class';
|
import { isInternalStorageClass } from '../../../../utils/storage-class';
|
||||||
import { VOLUME_MODE, ACCESS_MODE } from '@pkg/harvester/config/types';
|
import { VOLUME_MODE } from '@pkg/harvester/config/types';
|
||||||
|
|
||||||
const { READ_WRITE_MANY, READ_WRITE_ONCE } = ACCESS_MODE;
|
|
||||||
|
|
||||||
export default {
|
export default {
|
||||||
name: 'HarvesterEditVolume',
|
name: 'HarvesterEditVolume',
|
||||||
@@ -25,7 +22,7 @@ export default {
|
|||||||
emits: ['update'],
|
emits: ['update'],
|
||||||
|
|
||||||
components: {
|
components: {
|
||||||
InputOrDisplay, Loading, LabeledInput, LabeledSelect, UnitInput, LabelValue, DiskPerformanceOptions
|
InputOrDisplay, Loading, LabeledInput, LabeledSelect, UnitInput, LabelValue
|
||||||
},
|
},
|
||||||
|
|
||||||
props: {
|
props: {
|
||||||
@@ -208,7 +205,7 @@ export default {
|
|||||||
|
|
||||||
getAccessMode(storageClassName) {
|
getAccessMode(storageClassName) {
|
||||||
if (!this.longhornV2LVMSupport) {
|
if (!this.longhornV2LVMSupport) {
|
||||||
return READ_WRITE_MANY;
|
return 'ReadWriteMany';
|
||||||
}
|
}
|
||||||
|
|
||||||
const storageClass = this.storageClasses.find((sc) => sc.name === storageClassName);
|
const storageClass = this.storageClasses.find((sc) => sc.name === storageClassName);
|
||||||
@@ -219,7 +216,7 @@ export default {
|
|||||||
readWriteOnce = storageClass.provisioner === LVM_DRIVER || (!this.thirdPartyStorageClassEnabled && storageClass.parameters?.dataEngine === DATA_ENGINE_V2);
|
readWriteOnce = storageClass.provisioner === LVM_DRIVER || (!this.thirdPartyStorageClassEnabled && storageClass.parameters?.dataEngine === DATA_ENGINE_V2);
|
||||||
}
|
}
|
||||||
|
|
||||||
return readWriteOnce ? READ_WRITE_ONCE : READ_WRITE_MANY;
|
return readWriteOnce ? 'ReadWriteOnce' : 'ReadWriteMany';
|
||||||
},
|
},
|
||||||
|
|
||||||
update() {
|
update() {
|
||||||
@@ -363,11 +360,6 @@ export default {
|
|||||||
</InputOrDisplay>
|
</InputOrDisplay>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<DiskPerformanceOptions
|
|
||||||
:value="value"
|
|
||||||
:mode="mode"
|
|
||||||
@update="update"
|
|
||||||
/>
|
|
||||||
<div class="row mb-20">
|
<div class="row mb-20">
|
||||||
<div
|
<div
|
||||||
v-if="value.volumeEncryptionFeatureEnabled && isView"
|
v-if="value.volumeEncryptionFeatureEnabled && isView"
|
||||||
|
|||||||
@@ -772,9 +772,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Volume
|
<Volume
|
||||||
v-model:value="diskRows"
|
v-model:value="diskRows"
|
||||||
v-model:block-multi-queue="blockMultiQueue"
|
|
||||||
v-model:io-threads-policy="ioThreadsPolicy"
|
|
||||||
v-model:io-thread-count="ioThreadCount"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
:custom-volume-mode="customVolumeMode"
|
:custom-volume-mode="customVolumeMode"
|
||||||
:namespace="value.metadata.namespace"
|
:namespace="value.metadata.namespace"
|
||||||
@@ -791,7 +788,6 @@ export default {
|
|||||||
>
|
>
|
||||||
<Network
|
<Network
|
||||||
v-model:value="networkRows"
|
v-model:value="networkRows"
|
||||||
v-model:network-boot-first="networkBootFirst"
|
|
||||||
:mode="mode"
|
:mode="mode"
|
||||||
:is-single="isSingle"
|
:is-single="isSingle"
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -286,7 +286,6 @@ harvester:
|
|||||||
createTemplate: Generate Template
|
createTemplate: Generate Template
|
||||||
enableMaintenance: Enable Maintenance Mode
|
enableMaintenance: Enable Maintenance Mode
|
||||||
disableMaintenance: Disable Maintenance Mode
|
disableMaintenance: Disable Maintenance Mode
|
||||||
clearMaintenance: Clear Maintenance Mode Error
|
|
||||||
enableCPUManager: Enable CPU Manager
|
enableCPUManager: Enable CPU Manager
|
||||||
disableCPUManager: Disable CPU Manager
|
disableCPUManager: Disable CPU Manager
|
||||||
cordon: Cordon
|
cordon: Cordon
|
||||||
@@ -801,56 +800,6 @@ harvester:
|
|||||||
setFirst: Set as root volume
|
setFirst: Set as root volume
|
||||||
saveVolume: Update Volume
|
saveVolume: Update Volume
|
||||||
encryption: Encryption
|
encryption: Encryption
|
||||||
performance:
|
|
||||||
title: Storage Performance Options
|
|
||||||
expand: Show high-performance options
|
|
||||||
collapse: Hide high-performance options
|
|
||||||
profile:
|
|
||||||
label: Performance Profile
|
|
||||||
tip: "\"High Performance\" applies a tuned preset (no host cache, native AIO, a dedicated I/O thread on the virtio bus). Choose \"Custom\" to set each option yourself."
|
|
||||||
default: Default (Balanced)
|
|
||||||
highPerformance: High Performance
|
|
||||||
custom: Custom
|
|
||||||
highProfileTip: This disk will use the virtio bus with host cache disabled, native AIO and a dedicated I/O thread.
|
|
||||||
cacheMode:
|
|
||||||
label: Cache Mode
|
|
||||||
tip: "How the host caches disk I/O. \"None\" (host cache disabled) is best for high-throughput guests on block storage; \"WriteBack\" favours performance; \"WriteThrough\" favours durability."
|
|
||||||
default: Default (hypervisor)
|
|
||||||
none: None (no host cache)
|
|
||||||
writeback: WriteBack
|
|
||||||
writethrough: WriteThrough
|
|
||||||
filesystemWarning: "\"None\" (O_DIRECT) requires storage that supports direct I/O. It is recommended only for Block volume mode; on Filesystem volumes the VM may fail to start."
|
|
||||||
ioMode:
|
|
||||||
label: I/O Mode
|
|
||||||
tip: "How QEMU submits I/O. \"Native\" (Linux AIO) offers the lowest overhead but requires host cache set to \"None\"; \"Threads\" uses a host thread pool."
|
|
||||||
default: Default (hypervisor)
|
|
||||||
native: Native (AIO)
|
|
||||||
threads: Threads
|
|
||||||
nativeRequiresNoCacheTip: Native I/O mode requires cache mode "None"; it has been set for you.
|
|
||||||
dedicatedIOThread:
|
|
||||||
label: Dedicated I/O Thread
|
|
||||||
tip: Allocate an exclusive libvirt I/O thread to this disk instead of sharing one. Useful for disks with heavy I/O. Enabling this on any disk turns on the VM's I/O threads policy.
|
|
||||||
busTip: High-performance features work best on the virtio bus.
|
|
||||||
diskPerformance:
|
|
||||||
title: High Performance (I/O Threads and Multi-Queue)
|
|
||||||
description: These settings apply to all volumes in the Virtual Machine and complement the per-volume options above.
|
|
||||||
expand: Show VM-wide high-performance options
|
|
||||||
collapse: Hide VM-wide high-performance options
|
|
||||||
blockMultiQueue:
|
|
||||||
label: Virtio Block Multi-Queue
|
|
||||||
tip: Map disk I/O to multiple queues so it is processed across multiple CPUs. Applies to virtio disks and requires a fixed CPU allocation (Harvester always sets one).
|
|
||||||
noVirtioTip: Add at least one disk on the virtio bus to enable Block Multi-Queue.
|
|
||||||
ioThreadsPolicy:
|
|
||||||
label: I/O Threads Policy
|
|
||||||
tip: "How libvirt allocates I/O threads. \"Shared\" uses one thread for all disks; \"Auto\" pools threads round-robin (up to ~2x vCPUs); \"Supplemental Pool\" lets you pick a fixed thread count and adds matching CPUs to the pod."
|
|
||||||
default: "Disabled (default)"
|
|
||||||
shared: Shared
|
|
||||||
auto: Auto
|
|
||||||
supplementalPool: Supplemental Pool
|
|
||||||
autoEnabledTip: A disk requests a dedicated I/O thread, so the policy is enabled (defaults to "Shared").
|
|
||||||
ioThreadCount:
|
|
||||||
label: I/O Thread Count
|
|
||||||
tip: Number of I/O threads for the supplemental pool. 4-8 is a common range depending on workload.
|
|
||||||
shareable:
|
shareable:
|
||||||
label: Shareable
|
label: Shareable
|
||||||
tip: Allow multiple virtual machines to attach and write to this volume simultaneously.
|
tip: Allow multiple virtual machines to attach and write to this volume simultaneously.
|
||||||
@@ -872,12 +821,6 @@ harvester:
|
|||||||
title: Network
|
title: Network
|
||||||
addNetwork: Add Network
|
addNetwork: Add Network
|
||||||
addPort: Add Port
|
addPort: Add Port
|
||||||
networkBoot:
|
|
||||||
label: Enable network boot (PXE)
|
|
||||||
tip: Adds this interface to the VM boot order so the guest firmware can boot from the network. Requires a DHCP/TFTP (PXE) server reachable on the selected network; the management network does not provide one.
|
|
||||||
order: Network boot order
|
|
||||||
first: Before volumes
|
|
||||||
last: After volumes
|
|
||||||
cloudConfig:
|
cloudConfig:
|
||||||
title: Cloud Configuration
|
title: Cloud Configuration
|
||||||
createTemplateTitle: 'Create {name}'
|
createTemplateTitle: 'Create {name}'
|
||||||
@@ -1054,8 +997,6 @@ harvester:
|
|||||||
createWithDataVolumeTooltip: Create Volume with Kubevirt/Containerized Data Importer way. It can fill accessMode/volumeMode automatically.
|
createWithDataVolumeTooltip: Create Volume with Kubevirt/Containerized Data Importer way. It can fill accessMode/volumeMode automatically.
|
||||||
showAdvanced: Show Advanced Options
|
showAdvanced: Show Advanced Options
|
||||||
hideAdvanced: Hide Advanced Options
|
hideAdvanced: Hide Advanced Options
|
||||||
performance:
|
|
||||||
pvcTip: These high-performance options are saved as defaults on the volume and applied when it is attached to a virtual machine as a disk.
|
|
||||||
source: Source
|
source: Source
|
||||||
kind: Kind
|
kind: Kind
|
||||||
sourceOptions:
|
sourceOptions:
|
||||||
@@ -2542,7 +2483,6 @@ advancedSettings:
|
|||||||
'harv-kubevirt-migration': 'Configure cluster-wide KubeVirt live migration parameters.'
|
'harv-kubevirt-migration': 'Configure cluster-wide KubeVirt live migration parameters.'
|
||||||
'harv-instance-manager-resources': 'Configure resource percentage reservations for Longhorn instance manager V1 and V2. Valid instance manager CPU range between 0 - 40.'
|
'harv-instance-manager-resources': 'Configure resource percentage reservations for Longhorn instance manager V1 and V2. Valid instance manager CPU range between 0 - 40.'
|
||||||
'harv-cluster-pod-security-standard': 'Enforce Kubernetes Pod Security Standards (PSS) at the cluster level.'
|
'harv-cluster-pod-security-standard': 'Enforce Kubernetes Pod Security Standards (PSS) at the cluster level.'
|
||||||
'harv-maintenance-mode-drain-timeout': 'Maintenance mode drain timeout in minutes. Use 0 to disable the timeout.'
|
|
||||||
|
|
||||||
typeLabel:
|
typeLabel:
|
||||||
kubevirt.io.virtualmachine: |-
|
kubevirt.io.virtualmachine: |-
|
||||||
|
|||||||
@@ -25,9 +25,7 @@ import { HCI } from '../../types';
|
|||||||
import { parseVolumeClaimTemplates, EMPTY_IMAGE } from '../../utils/vm';
|
import { parseVolumeClaimTemplates, EMPTY_IMAGE } from '../../utils/vm';
|
||||||
import impl, { QGA_JSON, USB_TABLET } from './impl';
|
import impl, { QGA_JSON, USB_TABLET } from './impl';
|
||||||
import { GIBIBYTE } from '../../utils/unit';
|
import { GIBIBYTE } from '../../utils/unit';
|
||||||
import { VOLUME_MODE, ACCESS_MODE, FILESYSTEM_SOURCE_TYPE } from '@pkg/harvester/config/types';
|
import { VOLUME_MODE, FILESYSTEM_SOURCE_TYPE } from '@pkg/harvester/config/types';
|
||||||
|
|
||||||
const { READ_WRITE_MANY } = ACCESS_MODE;
|
|
||||||
|
|
||||||
const LONGHORN_V2_DATA_ENGINE = 'longhorn-system/v2-data-engine';
|
const LONGHORN_V2_DATA_ENGINE = 'longhorn-system/v2-data-engine';
|
||||||
|
|
||||||
@@ -160,7 +158,6 @@ export default {
|
|||||||
imageId: '',
|
imageId: '',
|
||||||
diskRows: [],
|
diskRows: [],
|
||||||
networkRows: [],
|
networkRows: [],
|
||||||
networkBootFirst: true,
|
|
||||||
filesystemRows: [],
|
filesystemRows: [],
|
||||||
machineType: '',
|
machineType: '',
|
||||||
machineTypes: [],
|
machineTypes: [],
|
||||||
@@ -196,10 +193,6 @@ export default {
|
|||||||
cpuPinning: false,
|
cpuPinning: false,
|
||||||
cpuModel: '',
|
cpuModel: '',
|
||||||
sysprep: { secretName: '', xmlContent: '' },
|
sysprep: { secretName: '', xmlContent: '' },
|
||||||
// KubeVirt high-performance VM-level features
|
|
||||||
blockMultiQueue: false,
|
|
||||||
ioThreadsPolicy: '',
|
|
||||||
ioThreadCount: 2,
|
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -283,7 +276,7 @@ export default {
|
|||||||
},
|
},
|
||||||
|
|
||||||
customAccessMode() {
|
customAccessMode() {
|
||||||
return this.storageClassSetting.accessModes || READ_WRITE_MANY;
|
return this.storageClassSetting.accessModes || 'ReadWriteMany';
|
||||||
},
|
},
|
||||||
|
|
||||||
isWindows() {
|
isWindows() {
|
||||||
@@ -385,7 +378,6 @@ export default {
|
|||||||
const diskRows = this.getDiskRows(vm, volumeBackups);
|
const diskRows = this.getDiskRows(vm, volumeBackups);
|
||||||
|
|
||||||
const networkRows = this.getNetworkRows(vm, { fromTemplate, init });
|
const networkRows = this.getNetworkRows(vm, { fromTemplate, init });
|
||||||
const networkBootFirst = this.isNetworkBootFirst(spec);
|
|
||||||
const hasCreateVolumes = this.getHasCreatedVolumes(spec) || [];
|
const hasCreateVolumes = this.getHasCreatedVolumes(spec) || [];
|
||||||
|
|
||||||
let { userData = undefined, networkData = undefined } = this.getCloudInitNoCloud(spec);
|
let { userData = undefined, networkData = undefined } = this.getCloudInitNoCloud(spec);
|
||||||
@@ -415,10 +407,6 @@ export default {
|
|||||||
const cpuPinning = this.isCpuPinning(spec);
|
const cpuPinning = this.isCpuPinning(spec);
|
||||||
const cpuModel = spec.template.spec.domain.cpu?.model || '';
|
const cpuModel = spec.template.spec.domain.cpu?.model || '';
|
||||||
|
|
||||||
const blockMultiQueue = spec.template.spec.domain?.devices?.blockMultiQueue || false;
|
|
||||||
const ioThreadsPolicy = spec.template.spec.domain?.ioThreadsPolicy || '';
|
|
||||||
const ioThreadCount = spec.template.spec.domain?.ioThreads?.supplementalPoolThreadCount || 2;
|
|
||||||
|
|
||||||
const secretRef = this.getSecret(spec);
|
const secretRef = this.getSecret(spec);
|
||||||
const accessCredentials = this.getAccessCredentials(spec);
|
const accessCredentials = this.getAccessCredentials(spec);
|
||||||
|
|
||||||
@@ -457,13 +445,8 @@ export default {
|
|||||||
this['cpuPinning'] = cpuPinning;
|
this['cpuPinning'] = cpuPinning;
|
||||||
this['cpuModel'] = cpuModel;
|
this['cpuModel'] = cpuModel;
|
||||||
|
|
||||||
this['blockMultiQueue'] = blockMultiQueue;
|
|
||||||
this['ioThreadsPolicy'] = ioThreadsPolicy;
|
|
||||||
this['ioThreadCount'] = ioThreadCount;
|
|
||||||
|
|
||||||
this['hasCreateVolumes'] = hasCreateVolumes;
|
this['hasCreateVolumes'] = hasCreateVolumes;
|
||||||
this['networkRows'] = networkRows;
|
this['networkRows'] = networkRows;
|
||||||
this['networkBootFirst'] = networkBootFirst;
|
|
||||||
this['imageId'] = imageId;
|
this['imageId'] = imageId;
|
||||||
|
|
||||||
this['diskRows'] = diskRows;
|
this['diskRows'] = diskRows;
|
||||||
@@ -521,7 +504,7 @@ export default {
|
|||||||
id: randomStr(5),
|
id: randomStr(5),
|
||||||
source: SOURCE_TYPE.IMAGE,
|
source: SOURCE_TYPE.IMAGE,
|
||||||
name: 'disk-0',
|
name: 'disk-0',
|
||||||
accessMode: READ_WRITE_MANY, // root disk only support LHv1 volume, should be RWX
|
accessMode: 'ReadWriteMany', // root disk only support LHv1 volume, should be RWX
|
||||||
bus,
|
bus,
|
||||||
volumeName: '',
|
volumeName: '',
|
||||||
size,
|
size,
|
||||||
@@ -529,9 +512,6 @@ export default {
|
|||||||
storageClassName: '',
|
storageClassName: '',
|
||||||
image: this.imageId,
|
image: this.imageId,
|
||||||
volumeMode: VOLUME_MODE.BLOCK,
|
volumeMode: VOLUME_MODE.BLOCK,
|
||||||
cache: '',
|
|
||||||
io: '',
|
|
||||||
dedicatedIOThread: false,
|
|
||||||
isEncrypted,
|
isEncrypted,
|
||||||
volumeBackups,
|
volumeBackups,
|
||||||
});
|
});
|
||||||
@@ -590,7 +570,7 @@ export default {
|
|||||||
const pvcResource = allPVCs.find( (O) => O.id === `${ namespace }/${ volume?.persistentVolumeClaim?.claimName }`);
|
const pvcResource = allPVCs.find( (O) => O.id === `${ namespace }/${ volume?.persistentVolumeClaim?.claimName }`);
|
||||||
|
|
||||||
source = SOURCE_TYPE.ATTACH_VOLUME;
|
source = SOURCE_TYPE.ATTACH_VOLUME;
|
||||||
accessMode = pvcResource?.spec?.accessModes?.[0] || READ_WRITE_MANY;
|
accessMode = pvcResource?.spec?.accessModes?.[0] || 'ReadWriteMany';
|
||||||
size = pvcResource?.spec?.resources?.requests?.storage || '10Gi';
|
size = pvcResource?.spec?.resources?.requests?.storage || '10Gi';
|
||||||
storageClassName = pvcResource?.spec?.storageClassName;
|
storageClassName = pvcResource?.spec?.storageClassName;
|
||||||
volumeMode = pvcResource?.spec?.volumeMode || VOLUME_MODE.BLOCK;
|
volumeMode = pvcResource?.spec?.volumeMode || VOLUME_MODE.BLOCK;
|
||||||
@@ -636,9 +616,6 @@ export default {
|
|||||||
type,
|
type,
|
||||||
storageClassName,
|
storageClassName,
|
||||||
hotpluggable,
|
hotpluggable,
|
||||||
cache: DISK?.cache || '',
|
|
||||||
io: DISK?.io || '',
|
|
||||||
dedicatedIOThread: DISK?.dedicatedIOThread || false,
|
|
||||||
shareable: DISK.shareable || false,
|
shareable: DISK.shareable || false,
|
||||||
volumeStatus,
|
volumeStatus,
|
||||||
dataSource,
|
dataSource,
|
||||||
@@ -679,29 +656,12 @@ export default {
|
|||||||
model: I.model,
|
model: I.model,
|
||||||
networkName: isPod ? MANAGEMENT_NETWORK : network?.multus?.networkName,
|
networkName: isPod ? MANAGEMENT_NETWORK : network?.multus?.networkName,
|
||||||
staticIp: annotations[`${ staticIpPrefix }${ I.name }`] || '',
|
staticIp: annotations[`${ staticIpPrefix }${ I.name }`] || '',
|
||||||
networkBoot: !!I.bootOrder,
|
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
return out;
|
return out;
|
||||||
},
|
},
|
||||||
|
|
||||||
/**
|
|
||||||
* Network boot devices are placed either before or after all volumes in the boot sequence.
|
|
||||||
* Derive which one from an existing spec, so a round trip through the form keeps it.
|
|
||||||
*/
|
|
||||||
isNetworkBootFirst(spec) {
|
|
||||||
const devices = spec?.template?.spec?.domain?.devices || {};
|
|
||||||
const nicOrders = (devices.interfaces || []).map((I) => I.bootOrder).filter(Boolean);
|
|
||||||
const diskOrders = (devices.disks || []).map((D) => D.bootOrder).filter(Boolean);
|
|
||||||
|
|
||||||
if (nicOrders.length === 0 || diskOrders.length === 0) {
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
return Math.min(...nicOrders) < Math.min(...diskOrders);
|
|
||||||
},
|
|
||||||
|
|
||||||
parseVM() {
|
parseVM() {
|
||||||
this.userData = this.getUserData({ osType: this.osType, installAgent: this.installAgent });
|
this.userData = this.getUserData({ osType: this.osType, installAgent: this.installAgent });
|
||||||
this.parseOther();
|
this.parseOther();
|
||||||
@@ -914,10 +874,9 @@ export default {
|
|||||||
const disks = [];
|
const disks = [];
|
||||||
const volumes = [];
|
const volumes = [];
|
||||||
const volumeClaimTemplates = [];
|
const volumeClaimTemplates = [];
|
||||||
const bootOrderOffset = this.networkBootFirst ? this.networkRows.filter((R) => R.networkBoot).length : 0;
|
|
||||||
|
|
||||||
disk.forEach( (R, index) => {
|
disk.forEach( (R, index) => {
|
||||||
const _disk = this.parseDisk(R, index + bootOrderOffset);
|
const _disk = this.parseDisk(R, index);
|
||||||
|
|
||||||
disks.push(_disk);
|
disks.push(_disk);
|
||||||
|
|
||||||
@@ -1012,25 +971,9 @@ export default {
|
|||||||
// `shareable` is an attachment-level opt-in, remove the field
|
// `shareable` is an attachment-level opt-in, remove the field
|
||||||
// inherited from the old spec when the disk row no longer requests it
|
// inherited from the old spec when the disk row no longer requests it
|
||||||
mergedDisks.forEach((disk) => {
|
mergedDisks.forEach((disk) => {
|
||||||
const parsed = disks.find((D) => D.name === disk.name);
|
if (disk.shareable && !disks.find((D) => D.name === disk.name)?.shareable) {
|
||||||
|
|
||||||
if (disk.shareable && !parsed?.shareable) {
|
|
||||||
delete disk.shareable;
|
delete disk.shareable;
|
||||||
}
|
}
|
||||||
|
|
||||||
// High-performance fields are only serialized when requested (see
|
|
||||||
// parseDisk). When editing, mergeDeviceList would otherwise keep the
|
|
||||||
// previous spec's cache/io/dedicatedIOThread even after the row is
|
|
||||||
// switched back to "Default" or the dedicated I/O thread is unchecked,
|
|
||||||
// silently preserving stale values — strip them so the disk matches
|
|
||||||
// what the row actually requests.
|
|
||||||
if (parsed) {
|
|
||||||
['cache', 'io', 'dedicatedIOThread'].forEach((field) => {
|
|
||||||
if (!parsed[field] && field in disk) {
|
|
||||||
delete disk[field];
|
|
||||||
}
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
|
|
||||||
let spec = {
|
let spec = {
|
||||||
@@ -1067,35 +1010,6 @@ export default {
|
|||||||
delete spec.template.spec.volumes;
|
delete spec.template.spec.volumes;
|
||||||
}
|
}
|
||||||
|
|
||||||
// KubeVirt high-performance VM-level features (I/O threads & block multi-queue).
|
|
||||||
const domainRef = spec.template.spec.domain;
|
|
||||||
const hasDedicatedIOThread = mergedDisks.some((D) => D.dedicatedIOThread);
|
|
||||||
// If any disk requests a dedicated I/O thread, KubeVirt requires a policy;
|
|
||||||
// default it to "shared" so the dedicated thread is honored.
|
|
||||||
let ioThreadsPolicy = this.ioThreadsPolicy;
|
|
||||||
|
|
||||||
if (hasDedicatedIOThread && !ioThreadsPolicy) {
|
|
||||||
ioThreadsPolicy = 'shared';
|
|
||||||
}
|
|
||||||
|
|
||||||
if (ioThreadsPolicy) {
|
|
||||||
domainRef.ioThreadsPolicy = ioThreadsPolicy;
|
|
||||||
} else {
|
|
||||||
delete domainRef.ioThreadsPolicy;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (ioThreadsPolicy === 'supplementalPool') {
|
|
||||||
domainRef.ioThreads = { supplementalPoolThreadCount: Number(this.ioThreadCount) || 1 };
|
|
||||||
} else {
|
|
||||||
delete domainRef.ioThreads;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (this.blockMultiQueue) {
|
|
||||||
domainRef.devices.blockMultiQueue = true;
|
|
||||||
} else {
|
|
||||||
delete domainRef.devices.blockMultiQueue;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (this.resourceType === HCI.VM) {
|
if (this.resourceType === HCI.VM) {
|
||||||
if (!this.isSingle) {
|
if (!this.isSingle) {
|
||||||
spec = this.multiVMScheduler(spec);
|
spec = this.multiVMScheduler(spec);
|
||||||
@@ -1175,11 +1089,9 @@ export default {
|
|||||||
const networks = [];
|
const networks = [];
|
||||||
const interfaces = [];
|
const interfaces = [];
|
||||||
|
|
||||||
let bootOrder = this.networkBootFirst ? 1 : this.diskRows.length + 1;
|
|
||||||
|
|
||||||
networkRow.forEach( (R) => {
|
networkRow.forEach( (R) => {
|
||||||
const _network = this.parseNetwork(R);
|
const _network = this.parseNetwork(R);
|
||||||
const _interface = this.parseInterface(R, R.networkBoot ? bootOrder++ : undefined);
|
const _interface = this.parseInterface(R);
|
||||||
|
|
||||||
networks.push(_network);
|
networks.push(_network);
|
||||||
interfaces.push(_interface);
|
interfaces.push(_interface);
|
||||||
@@ -1345,19 +1257,6 @@ export default {
|
|||||||
|
|
||||||
if (R.type === HARD_DISK) {
|
if (R.type === HARD_DISK) {
|
||||||
out.disk = { bus: R.bus };
|
out.disk = { bus: R.bus };
|
||||||
|
|
||||||
// KubeVirt high-performance per-disk features. `cache`, `io` and
|
|
||||||
// `dedicatedIOThread` live at the Disk level (siblings of `disk`), not
|
|
||||||
// inside the DiskTarget. See disks_and_volumes.md#high-performance-features.
|
|
||||||
if (R.cache) {
|
|
||||||
out.cache = R.cache;
|
|
||||||
}
|
|
||||||
if (R.io) {
|
|
||||||
out.io = R.io;
|
|
||||||
}
|
|
||||||
if (R.dedicatedIOThread) {
|
|
||||||
out.dedicatedIOThread = true;
|
|
||||||
}
|
|
||||||
} else if (R.type === CD_ROM) {
|
} else if (R.type === CD_ROM) {
|
||||||
out.cdrom = { bus: R.bus };
|
out.cdrom = { bus: R.bus };
|
||||||
}
|
}
|
||||||
@@ -1416,9 +1315,8 @@ export default {
|
|||||||
case SOURCE_TYPE.IMAGE: {
|
case SOURCE_TYPE.IMAGE: {
|
||||||
const image = this.images.find( (I) => R.image === I.id);
|
const image = this.images.find( (I) => R.image === I.id);
|
||||||
|
|
||||||
out.spec.storageClassName = R.realName ? R.storageClassName : (R.storageClassName || image?.storageClassName);
|
|
||||||
|
|
||||||
if (image) {
|
if (image) {
|
||||||
|
out.spec.storageClassName = image.storageClassName;
|
||||||
out.metadata.annotations = { [HCI_ANNOTATIONS.IMAGE_ID]: image.id };
|
out.metadata.annotations = { [HCI_ANNOTATIONS.IMAGE_ID]: image.id };
|
||||||
} else {
|
} else {
|
||||||
out.metadata.annotations = { [HCI_ANNOTATIONS.IMAGE_ID]: '' };
|
out.metadata.annotations = { [HCI_ANNOTATIONS.IMAGE_ID]: '' };
|
||||||
@@ -1435,7 +1333,7 @@ export default {
|
|||||||
return arr.map( (id) => this.getSSHValue(id)).filter( (O) => O !== undefined);
|
return arr.map( (id) => this.getSSHValue(id)).filter( (O) => O !== undefined);
|
||||||
},
|
},
|
||||||
|
|
||||||
parseInterface(R, bootOrder) {
|
parseInterface(R) {
|
||||||
const _interface = {};
|
const _interface = {};
|
||||||
const type = R.type;
|
const type = R.type;
|
||||||
|
|
||||||
@@ -1445,10 +1343,6 @@ export default {
|
|||||||
_interface.macAddress = R.macAddress;
|
_interface.macAddress = R.macAddress;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (bootOrder) {
|
|
||||||
_interface.bootOrder = bootOrder;
|
|
||||||
}
|
|
||||||
|
|
||||||
_interface.model = R.model;
|
_interface.model = R.model;
|
||||||
_interface.name = R.name;
|
_interface.name = R.name;
|
||||||
|
|
||||||
@@ -1956,11 +1850,6 @@ export default {
|
|||||||
delete merged['bridge'];
|
delete merged['bridge'];
|
||||||
}
|
}
|
||||||
|
|
||||||
// boot order is owned by the form, don't inherit a stale one from the old spec
|
|
||||||
if (!iface.bootOrder) {
|
|
||||||
delete merged.bootOrder;
|
|
||||||
}
|
|
||||||
|
|
||||||
return merged;
|
return merged;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -23,13 +23,6 @@ const ALLOW_SYSTEM_LABEL_KEYS = [
|
|||||||
|
|
||||||
const HEALTHY = 'healthy';
|
const HEALTHY = 'healthy';
|
||||||
const WARNING = 'warning';
|
const WARNING = 'warning';
|
||||||
const MAINTENANCE_MODE = 'MaintenanceMode';
|
|
||||||
const MAINTENANCE_ERROR = 'Error';
|
|
||||||
const MAINTENANCE_ENTERING_REASONS = ['Validating', 'Draining', 'Evacuating'];
|
|
||||||
const MAINTENANCE_COMPLETED = 'Completed';
|
|
||||||
// Legacy `harvesterhci.io/maintain-status` annotation values (clusters < v1.10)
|
|
||||||
const LEGACY_MAINTENANCE_RUNNING = 'running';
|
|
||||||
const LEGACY_MAINTENANCE_COMPLETED = 'completed';
|
|
||||||
|
|
||||||
export default class HciNode extends HarvesterResource {
|
export default class HciNode extends HarvesterResource {
|
||||||
get _availableActions() {
|
get _availableActions() {
|
||||||
@@ -65,14 +58,6 @@ export default class HciNode extends HarvesterResource {
|
|||||||
total: 1
|
total: 1
|
||||||
};
|
};
|
||||||
|
|
||||||
const clearMaintenance = {
|
|
||||||
action: 'clearMaintenanceMode',
|
|
||||||
enabled: this.hasAction('clearMaintenanceMode'),
|
|
||||||
icon: 'icon icon-fw icon-close',
|
|
||||||
label: this.t('harvester.action.clearMaintenance'),
|
|
||||||
total: 1
|
|
||||||
};
|
|
||||||
|
|
||||||
const enableCPUManager = {
|
const enableCPUManager = {
|
||||||
action: 'enableCPUManager',
|
action: 'enableCPUManager',
|
||||||
enabled: this.cpuPinningFeatureEnabled && this.hasAction('enableCPUManager') && !this.isCPUManagerEnableInProgress && !this.isCPUManagerEnabled && !this.isEtcd, // witness node doesn't have CPU manager
|
enabled: this.cpuPinningFeatureEnabled && this.hasAction('enableCPUManager') && !this.isCPUManagerEnableInProgress && !this.isCPUManagerEnabled && !this.isEtcd, // witness node doesn't have CPU manager
|
||||||
@@ -118,7 +103,6 @@ export default class HciNode extends HarvesterResource {
|
|||||||
uncordon,
|
uncordon,
|
||||||
enableMaintenance,
|
enableMaintenance,
|
||||||
disableMaintenance,
|
disableMaintenance,
|
||||||
clearMaintenance,
|
|
||||||
enableCPUManager,
|
enableCPUManager,
|
||||||
disableCPUManager,
|
disableCPUManager,
|
||||||
shutDown,
|
shutDown,
|
||||||
@@ -214,10 +198,6 @@ export default class HciNode extends HarvesterResource {
|
|||||||
}
|
}
|
||||||
|
|
||||||
get stateDisplay() {
|
get stateDisplay() {
|
||||||
if (this.isMaintenanceModeError) {
|
|
||||||
return super.stateDisplay;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (this.isEnteringMaintenance) {
|
if (this.isEnteringMaintenance) {
|
||||||
return 'Entering maintenance mode';
|
return 'Entering maintenance mode';
|
||||||
}
|
}
|
||||||
@@ -266,10 +246,6 @@ export default class HciNode extends HarvesterResource {
|
|||||||
}
|
}
|
||||||
|
|
||||||
get stateDescription() {
|
get stateDescription() {
|
||||||
if (this.isMaintenanceModeError) {
|
|
||||||
return super.stateDescription;
|
|
||||||
}
|
|
||||||
|
|
||||||
const currentIP = this.metadata?.annotations?.[HCI_ANNOTATIONS.CURRENT_IP];
|
const currentIP = this.metadata?.annotations?.[HCI_ANNOTATIONS.CURRENT_IP];
|
||||||
const initIP = this.metadata?.annotations?.[HCI_ANNOTATIONS.INIT_IP];
|
const initIP = this.metadata?.annotations?.[HCI_ANNOTATIONS.INIT_IP];
|
||||||
|
|
||||||
@@ -349,11 +325,7 @@ export default class HciNode extends HarvesterResource {
|
|||||||
}
|
}
|
||||||
|
|
||||||
disableMaintenanceMode() {
|
disableMaintenanceMode() {
|
||||||
this.doActionGrowl('disableMaintenanceMode', {});
|
this.doAction('disableMaintenanceMode', {});
|
||||||
}
|
|
||||||
|
|
||||||
clearMaintenanceMode() {
|
|
||||||
this.doActionGrowl('clearMaintenanceMode', {});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
enableCPUManager() {
|
enableCPUManager() {
|
||||||
@@ -371,32 +343,11 @@ export default class HciNode extends HarvesterResource {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
get maintenanceModeCondition() {
|
|
||||||
return (this.status?.conditions || []).find(
|
|
||||||
(c) => c.type === MAINTENANCE_MODE
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
get maintenanceModeConditionsEnabled() {
|
|
||||||
return this.$rootGetters['harvester-common/getFeatureEnabled']('maintenanceModeConditions');
|
|
||||||
}
|
|
||||||
|
|
||||||
// Clusters < v1.10 only expose the `harvesterhci.io/maintain-status` annotation
|
|
||||||
get legacyMaintenanceStatus() {
|
|
||||||
return this.metadata?.annotations?.[HCI_ANNOTATIONS.MAINTENANCE_STATUS];
|
|
||||||
}
|
|
||||||
|
|
||||||
get isMaintenanceModeError() {
|
|
||||||
return this.maintenanceModeConditionsEnabled && this.maintenanceModeCondition?.reason === MAINTENANCE_ERROR;
|
|
||||||
}
|
|
||||||
|
|
||||||
get isMigratable() {
|
get isMigratable() {
|
||||||
const states = ['in-progress', 'unavailable'];
|
const states = ['in-progress', 'unavailable'];
|
||||||
|
|
||||||
const engaged = this.maintenanceModeConditionsEnabled ? this.maintenanceModeCondition?.status === 'True' : !!this.legacyMaintenanceStatus;
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
!engaged &&
|
!this.metadata?.annotations?.[HCI_ANNOTATIONS.MAINTENANCE_STATUS] &&
|
||||||
!this.isUnSchedulable &&
|
!this.isUnSchedulable &&
|
||||||
!states.includes(this.state)
|
!states.includes(this.state)
|
||||||
);
|
);
|
||||||
@@ -411,26 +362,17 @@ export default class HciNode extends HarvesterResource {
|
|||||||
}
|
}
|
||||||
|
|
||||||
get isEnteringMaintenance() {
|
get isEnteringMaintenance() {
|
||||||
if (!this.maintenanceModeConditionsEnabled) {
|
|
||||||
return this.legacyMaintenanceStatus === LEGACY_MAINTENANCE_RUNNING;
|
|
||||||
}
|
|
||||||
|
|
||||||
const cond = this.maintenanceModeCondition;
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
cond?.status === 'True' &&
|
this.metadata?.annotations?.[HCI_ANNOTATIONS.MAINTENANCE_STATUS] ===
|
||||||
MAINTENANCE_ENTERING_REASONS.includes(cond?.reason)
|
'running'
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
get isMaintenance() {
|
get isMaintenance() {
|
||||||
if (!this.maintenanceModeConditionsEnabled) {
|
return (
|
||||||
return this.legacyMaintenanceStatus === LEGACY_MAINTENANCE_COMPLETED;
|
this.metadata?.annotations?.[HCI_ANNOTATIONS.MAINTENANCE_STATUS] ===
|
||||||
}
|
'completed'
|
||||||
|
);
|
||||||
const cond = this.maintenanceModeCondition;
|
|
||||||
|
|
||||||
return cond?.status === 'True' && cond?.reason === MAINTENANCE_COMPLETED;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
get cpuPinningFeatureEnabled() {
|
get cpuPinningFeatureEnabled() {
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "harvester",
|
"name": "harvester",
|
||||||
"description": "Rancher UI Extension for Harvester",
|
"description": "Rancher UI Extension for Harvester",
|
||||||
"version": "1.10.0-dev",
|
"version": "1.9.1-rc3",
|
||||||
"private": false,
|
"private": false,
|
||||||
"rancher": {
|
"rancher": {
|
||||||
"annotations": {
|
"annotations": {
|
||||||
|
|||||||
@@ -11,12 +11,3 @@ export function parseVolumeClaimTemplates(data) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export const EMPTY_IMAGE = 'EMPTY_IMAGE';
|
export const EMPTY_IMAGE = 'EMPTY_IMAGE';
|
||||||
|
|
||||||
/**
|
|
||||||
* Disks and interfaces that take part in the boot sequence, sorted by boot order.
|
|
||||||
*/
|
|
||||||
export function getBootDevices(devices = {}) {
|
|
||||||
return [...(devices.disks || []), ...(devices.interfaces || [])]
|
|
||||||
.filter((device) => !!device.bootOrder)
|
|
||||||
.sort((a, b) => a.bootOrder - b.bootOrder);
|
|
||||||
}
|
|
||||||
|
|||||||
Reference in New Issue
Block a user