* feat: add the Kube-OVN VPC Egress Gateways page
List, create and edit VpcEgressGateway resources under Overlay Networks >
NAT & Internet, right below the NAT gateways, which are now labeled NAT
Gateways. The form covers the VPC, replicas, internal and external
subnets, SNAT policies, internal and external IPs, BFD and the bandwidth
limit, and keeps the fields it does not show.
* feat: add the VPC BFD port and link the Egress Gateway BFD warning to it
The VPC form gets a BFD Port tab with the enabled switch and its IP,
which an Egress Gateway with BFD needs. The gateway form now checks the
VPC's spec.bfdPort instead of a spec.bfd field that VPCs don't have, and
its warning links to the VPC. Bandwidth also takes quantities such as
1Gi, and a gateway that only uses selectors no longer needs a policy.
* feat: check the Egress Gateway and BFD port against what Kube-OVN accepts
Kube-OVN runs as a secondary CNI in Harvester, so an Egress Gateway's
internal subnet has to sit on a virtual machine network and its external
subnet on a network attachment; the subnet lists now offer only those.
The internal and external IPs must be unique and inside their subnet,
other than its gateway, and the two subnets must differ. Selectors don't
work in that mode, so a gateway needs a policy again. Policies set with
IP blocks show them, and BFD intervals hidden while BFD is off fall back
to their defaults.
Save stays disabled while either form is invalid, each field shows its
own error, and a tab with errors is marked. The VPC's BFD port IP can't
be in one of its subnets, its tab warns when it is turned off while
gateways of the VPC use BFD, and the gateway's BFD warning opens the
VPC's BFD Port tab in a new tab.
* fix: show why Save is disabled on the Egress Gateway and VPC forms
Every field that can block Save shows its own message once touched:
the name, the VPC and both subnets, which have none when left empty.
When the chosen VPC has no subnet on a virtual machine network, the
Internal Subnet placeholder says so.
A subnet can only be in one policy: the gateway leaves a source out of
SNAT when any policy has SNAT off for it, so the same subnet in a second
policy would silently ignore one of them. Enable SNAT explains what
turning it off needs.
* fix: keep one Egress Gateway policy for each SNAT setting
Kube-OVN merges the sources of every policy with the same SNAT setting,
so a second policy with SNAT on (or off) only adds to the first one.
The form now flags it on the second policy, Add Policy adds the setting
that isn't used yet and goes away once both exist, and the Policies tab
says a gateway has at most two policies. Policies with IP blocks are
left out of the check, since the form can't move those.
* refactor: ask for the Egress Gateway subnets with and without SNAT
Kube-OVN puts the sources of every policy into two sets, with SNAT and
without, and leaves a source out of SNAT when any policy has SNAT off
for it. A list of policies with a checkbox each let the form build
policies that only repeated or silently overrode each other, so the
Policies tab now asks for those two sets: Subnets with SNAT and Subnets
without SNAT, a subnet in one list only and at least one subnet in all.
Saving writes one policy for each list that has subnets.
Editing reads existing policies the way Kube-OVN applies them, so a
subnet that was in both lands in Subnets without SNAT, and IP blocks
set outside the form are kept and shown read-only.
* refactor: go back to the Egress Gateway policy list
The VpcEgressGateway CRD and the issue describe policies as a list,
each with snat and subnets, and Kube-OVN accepts any number of them:
policies with the same SNAT setting just work together. The two subnet
lists hid that shape and rewrote existing policies, and they couldn't
mark "one of these two" as required. This puts back the policy list,
where each policy needs a subnet and a subnet can be in one policy
only, which is the one case that changes what the gateway does. The
Policies tab now says how policies work together.
* refactor: ask for the Egress Gateway subnets with and without SNAT again
Kube-OVN only uses which subnets have SNAT and which don't, so two
lists, Subnets with SNAT and Subnets without SNAT, hold the same data
as the policy list, are clearer to fill in, and can't build a policy
that repeats or overrides another. Saving writes one policy for each
list that has subnets. Neither list is marked required: the Policies
tab says one subnet in either list is needed, and both lists show that
message once touched while they're empty.
* fix: show the Egress Gateway policy rule once for both subnet lists
One subnet in either list is enough, but a warning on each list read as
if both lists were required. The lists no longer show a warning; one
message under them says to select at least one subnet in either list
while both are empty, next to the tab mark and the disabled Save.
* fix: say why the Egress Gateway subnet lists are empty
The policy lists only offer subnets of the VPC chosen on the Basic tab,
so before a VPC is chosen they were empty with no reason given. They
now say to select a VPC on the Basic tab first, or that the chosen VPC
has no subnets.
* fix: make the Egress Gateway fields that need a VPC say so
Internal Subnet and both policy lists only offer subnets of the chosen
VPC, so they're disabled until a VPC is chosen and say to select one
first. The policy lists keep their dropdown attached to the field, so
it follows the field when a chip is removed instead of leaving a gap.
The BFD intervals are labeled Receive Interval and Transmit Interval,
which fit next to their unit, with a tooltip each.
* fix: keep the external subnet out of Egress Gateway policies and check usable IPs
Kube-OVN reroutes a policy's sources to the gateway, so the gateway's
own external subnet as a source would send its outbound traffic back
into it; the policy lists no longer offer it and the form flags it.
Static IPs must also be usable addresses: Kube-OVN assigns from the
network address + 1 to the broadcast address - 1, so those two are
rejected along with the gateway.
The policy rule is an error banner like the IP count rule, the BFD
multiplier has its own message, the IP Addresses and Bandwidth
instructions are hidden on the read-only page, and the VPC's warning
about gateways that need its BFD port reads right for one gateway.
* chore: declare ipaddr.js, which the subnet model imports
It was only installed as a dependency of webpack-dev-server.
* feat: support PrimaryCNI Egress Gateways
Kube-OVN v1.17 can send a gateway's traffic out through the pod network
when it isn't the primary CNI, as on Harvester. Such a gateway takes no
external subnet, external IPs or bandwidth, so the form couldn't save one.
The Basic tab now picks the external network, locked after creation, and
hides the fields PrimaryCNI doesn't take.
* fix: offer Primary CNI only when the cluster's CRD has it
Kube-OVN v1.16, in Harvester v1.10.0-rc1 and older, has no
externalNetworkMode and requires an external subnet, so a Primary CNI
gateway was rejected there. The form reads the CRD's schema definition
and only shows the External Network choice when the field exists.
---------
(cherry picked from commit e66b61d0d1)
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
Co-authored-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
When Longhorn installation is deferred, vmstate-persistence StorageClass is not created. Add prerequisite guidance in the VM form:
- Disable persistent TPM and EFI options when vmstate-persistence is unavailable
- Create mode: clear selections and show banner explaining how to add
Longhorn disk or create vmstate-persistence SC manually
- Edit mode: preserve existing values, keep options disabled, show banner
- Hide banner when vmstate-persistence exists or in View mode
(cherry picked from commit b3961a3483)
Signed-off-by: pohanhuang <pohan.huang@suse.com>
Co-authored-by: Po Han Huang <pohan.huang@suse.com>
* feat: align the storage performance options with the Rancher machine pool form
Show the storage performance profile on every volume instead of behind a
collapsible toggle, and move the VM-wide options to a plain Storage
Performance section in the Advanced Options tab. Put the Native I/O tip in
a live region so screen readers announce the cache mode change, use an
integer input for the I/O thread count, and use the same copy as the
Rancher form.
Skip the view-only backup row in the image and container volumes when it
has nothing to show, so it no longer adds an empty gap above the profile.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: announce the storage performance warnings and name the virtio requirement
- Put the bus tip and the Filesystem warning in an always-rendered status
region. They appear above the field being changed, so screen readers need
them announced.
- Say in the bus tip that a dedicated I/O thread needs the virtio bus, because
KubeVirt rejects it on any other bus.
- Mark I/O Thread Count as required while editing, like the Rancher form.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: state only the dedicated I/O thread requirement in the bus tip
Neither the Harvester docs nor KubeVirt tie cache mode or I/O mode to the bus,
so stop saying that those options work best on virtio.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
---------
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
(cherry picked from commit 12c28c08fa)
Co-authored-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: show quotes in high-performance storage hints and keep Custom profile
The Native I/O and I/O threads policy hints were passed to Banner as
:label="t(...)". t() escapes HTML and Banner escapes the label again,
so the quotes showed up as ". Use label-key instead, which renders
the string once.
Picking the Custom performance profile and then choosing options that
match the Default or High Performance preset flipped the selector back
to that preset. Keep an explicit Custom choice and only infer the
profile from the disk values otherwise.
Related: harvester/harvester#11550
* fix: only keep Custom profile when the user picked it
syncProfile() skipped re-detection whenever the profile was Custom,
including a Custom that was inferred from the disk values. In an
existing-volume row, switching from a volume with a WriteBack override
to one with High Performance values left the selector on Custom.
Track the user's explicit Custom choice in its own flag and use that
in the guard, so an inferred Custom still follows the disk values.
Related: harvester/harvester#11550
* test: cover the label-key hints of VMPerformanceOptions
Check that the I/O threads policy and no virtio disk hints are passed to Banner as label keys, so their quotes are not escaped twice, and that the I/O threads policy hint is hidden once a policy is set.
---------
(cherry picked from commit 840f9de73e)
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Co-authored-by: Alejandro Bonilla <abonilla@suse.com>
* fix(vm): block VM creation with invalid CloudInit YAML content
* fix(vm): add isWindows guard to validateCloudInit in template version
* fix: validate Windows CloudInit YAML on save
* fix: validate cloud-init by format in the VM mixin
Cloud-init picks the user data format from the first line, so scripts,
MIME messages and Jinja templates are valid without being YAML. Parsing
all user data blocked them, and it stopped any existing VM holding one
from being saved, even with nothing changed.
Only parse user data that starts with #cloud-config, and require a
mapping for it and for network data, because plain words are valid YAML
and were still saved.
Both forms already use the VM mixin, so the check moves there and shares
the header pattern with hasCloudConfigComment.
* fix: save other user data formats as typed and check text without a header
The form added #cloud-config to any user data that parses as YAML, so a
script was saved with the header and its lines folded together, and Edit
Config then failed the check on it. User data that starts with a script,
MIME or another cloud-init or Cloudbase-Init format is now saved as typed,
and any other text is checked as cloud-config, with or without the header,
because the form adds the header when saving it.
Editing only checks cloud-init that changed, so a VM saved before this
change can still be edited with the cloud-init it already has.
---------
(cherry picked from commit aa6d11a840)
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: a110605 <5744158+a110605@users.noreply.github.com>
Co-authored-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* chore(deps): bump @rancher/shell to 3.0.14
3.0.14 resolves [[name]] tokens in translations from values registered
as l10n globals, which the standalone UI needs to pick the product name.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: save cloud-config template edits with @rancher/shell 3.0.14
The YamlEditor of shell 3.0.14 no longer emits onChanges, so editing a
template saved its old cloud config. Copy the text from update:value,
which both shell versions emit.
Jest transforms @replit/codemirror-vim-core, an ESM-only dependency of
the new YamlEditor, like the dashboard does.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: keep the YAML editor heights with CodeMirror 6
The min-height rules targeted the CodeMirror 5 element, so the editors
shrank to their text.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: reject IP ranges the network settings don't support
The CIDR check of @rancher/shell 3.0.14 also accepts short forms such as
10.1/16, extra parts and IPv6, so the VM migration, RWX and storage
network settings saved them. Use a strict IPv4 CIDR check of our own.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: keep the look of the file selector buttons
The FileSelector of @rancher/shell 3.0.14 no longer takes button classes
and renders a medium secondary button. Pass the variant and size that
match the previous primary and secondary buttons.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: keep Enter in a migration wizard field on the same step
The Wizard of @rancher/shell 3.0.14 renders its step headers as submit
buttons, so Enter in a text field clicked the first one and jumped back
to step 1.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: show the created message after a restore, upgrade or upload
Since @rancher/shell 3.0.14, save() no longer shows the message for
resources with a generated name; callers show it with
notifyGeneratedName().
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* refactor: fold the logging output buffer with the CodeMirror 6 helpers
The YAML editor of @rancher/shell 3.0.14 is CodeMirror 6, and its
CodeMirror 5 methods are deprecated.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: keep the shell's table views off in standalone
@rancher/shell 3.0.14 turns its table views on for every list in the
standalone UI, as the server has no ui-configurable-tables feature and
the default is on. The table views drop the filters the lists put in the
table header, which also left the Images list empty. Add the feature,
disabled, to the management store in standalone only.
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* fix: reject zero-padded octets in IP ranges
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
---------
Signed-off-by: Marcelo Fukumoto <marcelo.fukumoto@suse.com>
* feat: move OS type, CPU model and system options to the VM Basics tab
OS Type, CPU Model and the CPU/system checkboxes (CPU pinning, USB
tablet, TPM, EFI, Secure Boot and their persistent-state options) are
core machine settings, but they were buried at the bottom of Advanced
Options. Show them on the Basics tab, next to CPU and memory.
Install Guest Agent stays in Advanced Options because it changes the
cloud config. It now sits right below the User Data editor (the data it
modifies) through a new optional slot in the Cloud Config component.
Only the placement changes; behaviour and validation are untouched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
* feat: follow the review on the VM Basics layout
- Basics now reads OS Type and CPU Model, then CPU and memory, then the
system checkboxes, the CPU Manager banner and the SSH key, in the order
proposed in review. The checkboxes sit in one wrapper; USB Tablet drops
its extra mt-20 and uses the plain `check` class like the others.
- Advanced Options puts Maintenance Strategy on the same row as Run
Strategy; Reserved Memory moves to its own row.
- The moved labels leave harvester.virtualMachine.advancedOptions: TPM,
EFI, Secure Boot and the persistent-state labels are now under
harvester.virtualMachine.systemOptions (also used by the template
version editor), and the CPU Manager banner text is under
harvester.virtualMachine.cpuPinning.cpuManager.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
* feat: match the VM template form and address review on the VM Basics layout
The VM template form still had OS Type, CPU Model and the CPU/system
checkboxes under Advanced Options, so creating a VM and creating a
template put them in different places. Use the same layout as the VM
form:
- Basics: OS Type and CPU Model, then CPU and memory, then the CPU
Pinning, USB Tablet, TPM, EFI and Secure Boot checkboxes (plus the
persistent-state options when they apply), then the SSH key.
- Advanced Options: Run Strategy and Maintenance Strategy on one row,
Reserved Memory on its own row, then Show more and Cloud Config.
Install Guest Agent sits right below the User Data editor through the
after-user-data slot.
Review follow-ups on both forms:
- OS Type shows an info icon in create mode warning that selecting an
image with an OS label on the Volumes tab may change the OS Type
selection, now that OS Type comes before the volumes.
- The CPU Manager banner under CPU Pinning is info in create mode, where
it only explains why the checkbox is disabled, and stays a warning in
edit mode, where it is about the restart.
Only placement and presentation change; behaviour and validation are
untouched.
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
---------
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Add an "Enable network boot (PXE)" option to bridge network interfaces and
a VM-level choice to place network boot devices before or after volumes.
The form now owns interface boot order: enabled NICs get sequential boot
orders ahead of or behind the volumes, and a stale bootOrder is no longer
inherited from the old spec.
This also fixes editing a VM whose interface bootOrder was set in YAML
(the documented workaround): the form used to renumber disks from 1 while
keeping the NIC's bootOrder, producing a duplicate that KubeVirt rejects.
The boot order shown on the VM, snapshot and backup detail pages now
includes network interfaces.
Related: harvester/harvester#3325
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat: expose KubeVirt high-performance storage features in VM and Volume UI
Adds UI to configure KubeVirt high-performance disk/storage settings that
were previously only reachable via VMBuilder/Terraform:
- Per-volume "Storage Performance Options": a performance profile
(Default / High Performance / Custom) exposing per-disk cache, io and
dedicatedIOThread on all disk types (VM image/root, new, existing,
container) and on the standalone Volume form.
- VM-wide "High Performance (I/O Threads and Multi-Queue)": blockMultiQueue
and ioThreadsPolicy (+ supplemental-pool thread count), shown only in the
VM section since these are domain-level and cannot be set per-PVC.
- Compatibility guardrails: io=native forces cache=none; cache=none on
Filesystem volumeMode warns; blockMultiQueue requires a virtio disk.
Ref: harvester/harvester#11550
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
* fix: address review feedback on high-performance storage UI
Resolves the Copilot review comments on #1133:
- Gate the whole feature behind a new `highPerformanceStorage` release
feature flag (v1.9.0) so older supported clusters never render the
controls or receive unsupported KubeVirt fields.
- Force Cache Mode to "none" whenever Native I/O is selected, including
from the "Default" ('') cache value, and disable every non-"none" cache
option (Default included) while Native is active. Previously the empty
cache value slipped past the guardrail and produced an invalid combo.
- Clear an already-enabled blockMultiQueue when the last virtio disk is
removed, so a disabled checkbox can no longer persist an invalid setting.
- Strip stale cache/io/dedicatedIOThread fields from the merged disk spec
when a regenerated disk no longer requests them, so switching a disk back
to "Default" (or unchecking Dedicated I/O Thread) while editing no longer
silently preserves the previous values.
- Expose the disclosure toggle's state to assistive tech via aria-expanded
and an expand/collapse aria-label.
- Add unit tests for the profile transitions and the Native/cache guardrails.
Ref: harvester/harvester#11550
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
* fix: address second-round review on high-performance storage UI
Resolves the two Copilot findings on #1133 and votdev's UX feedback on
harvester/harvester#11550:
- Restore the disk's original bus when the performance profile goes back
to "Default". The "High Performance" preset switches the bus to virtio,
but leaving the preset only cleared cache/io/dedicatedIOThread, so a
SATA/SCSI disk was silently left on virtio — a bus change that can make
an existing guest unbootable. The pre-preset bus is now remembered and
put back, unless the user picked a different bus themselves in the
meantime.
- Pass the VM-wide performance values from the VM detail page to the
shared Volume component. The mixin already parsed them via
getInitConfig(), but the detail caller never forwarded them, so
VMPerformanceOptions fell back to its prop defaults and hid itself in
view mode — configured blockMultiQueue / ioThreadsPolicy settings were
invisible. They are also refreshed in the value watcher so the panel
does not go stale.
- Make the VM-wide "High Performance" panel expandable/collapsible,
matching the per-volume "Storage Performance Options" disclosure. It
stays collapsed unless the VM already has something configured, so the
average user is not faced with specialist tuning controls by default.
- Fix the unit tests to use Vue Test Utils v2 mount options. They used
the v1 top-level `mocks` key, which VTU 2.x ignores, so every case
failed on mount. The repo has no jest config or test script, so this
was not caught. Add coverage for the bus save/restore behaviour.
Ref: harvester/harvester#11550
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
---------
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
The LVM add-on reaches GA in v1.9.1 and only supports dm-thin.
Gate the striped option behind a v1.9.1 feature flag, default new
LVM storage classes to dm-thin, and reset a cloned striped type so
older clusters keep the current behaviour.
Related issue: harvester/harvester#11731
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
* feat: add k3k addon UI
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add rancher-k3k addon UI
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: remove k3k edit page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: k3k addon description
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: vGPU doesn't display in edit VM page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: align PCI passthrough action buttons height
Match the enable/disable passthrough and Actions dropdown buttons to 40px and move the selected-count label below them.
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: project resource quota not set in POST API payload
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: guard onQuotasInput against undefined payload
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
Show a Shareable checkbox when attaching an existing volume whose
PVC is RWX Block and not provisioned by Longhorn. Checking it sets
disk.shareable and shows a data-corruption warning banner.
Related issue: harvester/harvester#9650
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
* feat(vm): allow Cloud Config for Windows guests
Currently the Cloud Config editor is completely hidden when a VM's
OS Type is set to Windows, and no `cloudinitdisk` volume or secret
is written to the VM spec even if the user has entered content.
This blocks a common Windows-on-Harvester workflow: using
Cloudbase-Init to run first-boot configuration (install VMDP,
enable OpenSSH server, add authorized_keys, join a domain, run
`runcmd` steps, etc.). Users on Windows today have to hand-edit the
VM YAML after creation to attach a cloudinitdisk, which is fragile
and undiscoverable.
Changes:
- Remove the `v-if="!isWindows"` on the CloudConfig component so
the editor is available for every OS type. The Sysprep editor
continues to render only for Windows, so Windows now gets both
panels; Linux is unchanged.
- Drop the `if (!this.isWindows)` guard around the cloudinitdisk
volume serialization so the disk is attached whenever the user
provided user-data or network-data, regardless of OS.
- Drop the `|| this.isWindows` early-return in `saveSecret` so the
cloud-init secret is persisted for Windows VMs too.
- `getInitUserData` now returns a bare `#cloud-config\n` header for
Windows instead of the Linux qemu-guest-agent runcmd template
(which would fail on Cloudbase-Init). VMDP installs the QGA on
Windows as a native service, so the runcmd path is not needed.
The "Install guest agent" checkbox stays disabled for Windows
because it specifically drives the Linux QGA-via-runcmd recipe.
Fixes point 2 of harvester/harvester#11124.
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
* fix(vm): do not clear cloud-config on isWindows watcher fire
The isWindows watcher runs on every change of the isWindows computed
property, including on mount when editing an existing Windows VM. Setting
this['userScript'] and this['networkScript'] to undefined at that point
wipes the cloud-config data that was just loaded from the existing VM's
cloudinit secret, so the Advanced -> Cloud Config editor shows empty
even though the VM has data on the wire.
Remove the two clears - Cloud Config is now supported for Windows guests
by this PR, so there is no reason to unset the user/network scripts when
the OS type is Windows. sshKey and installAgent remain gated (SSH keys
are injected via cloud-init on Linux only, and the qemu-guest-agent
package install checkbox does not apply to Windows).
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Co-authored-by: Volker Theile <vtheile@suse.com>
* refactor(vm): Get CloudInit working for VM templates
- Remove unnecessary osType watcher in cloud config. The watcher (see `pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineCloudConfig/DataTemplate.vue`) that cleared the cloud config template for Windows VMs is no longer necessary.
- Automatically strip the CloudInit `User Data` properties `package_update` and `packages` for OS type `Windows`.
Signed-off-by: Volker Theile <vtheile@suse.com>
---------
Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
Co-authored-by: Volker Theile <vtheile@suse.com>
* refactor: extract access mode strings to static ACCESS_MODE constant
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: destructure ACCESS_MODE variables in CDISettings.vue accessModeOptions
* refactor: destructure ACCESS_MODE at top level in all consumer files
* fix(lint): reorder imports to top of module in CDISettings, harvesterhci.io.volume, and VirtualMachineVolume
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
Co-authored-by: Andy Lee <andy.lee@suse.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* fix: regenerate stale cloud-init secret name after VM name change
When creating a VM, the cloud-init/sysprep secret name was generated
once and cached for the component's lifetime (needNewSecret is always
false during create). If a first create attempt was rejected by the
API (e.g. duplicate name) and the user corrected the name and retried,
the VM was created successfully but reused the secret name derived
from the rejected attempt, and any subsequent secret-creation failure
surfaced as a stale error after the VM already existed.
Now the secret name (and Windows sysprep secret name) is regenerated
whenever the VM name prefix used to generate it no longer matches the
current name, and is proactively reset on a failed create attempt so
retries always start fresh.
Fixesharvester/harvester#11174
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: remove console
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* feat: allow suer give static IP for VM
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add feature flag
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: allow user to select kube-system ns
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add NICs tab when creating overlay network
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: only show NIC tab if ns is kube-system
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add NAT & Internet tabs
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add provider networks / vlan edit pages
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add edit pages
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: review comments
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: allow user to select kube-system ns
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add NICs tab when creating overlay network
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: only show NIC tab if ns is kube-system
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add Host Network tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add Host Network edit page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add node selector tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: lint
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: add warning message if addon is not enabled or already hasone
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: some wordings in en-us.yaml
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add support for volume expansion in storage configuration
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update volume expansion wording
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: hide checkbox if feature flag is not enabled
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: revert unneeded change
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add VM display name annotation support in edit and list views
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: add display name checkbox and input field
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
when implementing the first version pci device passthrough,
we didn't have our own device plugin, then resource name was changed
after upgrade.
Right now, we already have our own device plugin, which we can control
resource name by our ourselves. So, we can remove old mechanism.
Signed-off-by: Jack Yu <jack.yu@suse.com>
* feat: add filesystem tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add filesystem tab in create VM page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update some wordings
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add support for filesystem feature flag and enable filesystem tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: remove unneeded wordings
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add support for filesystem feature flag and update icon button positioning
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: based on copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: remove wrong feature flag
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: vm template
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add filesystem tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add filesystem tab in create VM page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update some wordings
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add support for filesystem feature flag and enable filesystem tab
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: remove unneeded wordings
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add support for filesystem feature flag and update icon button positioning
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: based on copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: tab name
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add external connectivity option for subnets with corresponding tooltip
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: remove gatewayType from subnet spec when not needed
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update external connectivity feature to use NAT outgoing and improve tooltip descriptions
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: update subnet creation to correctly handle natOutgoing and improve comment clarity
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: improve tooltip clarity for external connectivity NAT option
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: vGPU / USB enable/disable actions needs to be hidden for read only users
Signed-off-by: Andy Lee <andy.lee@suse.com>
* style: add scoped styles for group actions in DeviceList component
Signed-off-by: Andy Lee <andy.lee@suse.com>
* style: remove width property from group actions in DeviceList components
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: update logging type in init function and improve SideNav visibility handling
Signed-off-by: Andy Lee <andy.lee@suse.com>
* fix: ensure canManageGroup only returns true for non-empty rows with updatable permissions
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add generic error for API response 40X
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: fallback error msg
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update error msg
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: based on comment
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: add banner in PCI Devices page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: based on copilot review
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: support advance option and creation from DataVolume
- advance option would let user change the accessMode/volumeMode
- creation from DataVolume could supports various scenario with
3rd-party storage
Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
* feat: add data migration action on volume page
Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
* refactor: use show advanced options link instead of checkbox
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add feature flag
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add feature flag for dataMigration action
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Vicente Cheng <freeze.bilsted@gmail.com>
Signed-off-by: Andy Lee <andy.lee@suse.com>
Co-authored-by: Andy Lee <andy.lee@suse.com>
* feat: add another filter button
Signed-off-by: Andy Lee <andy.lee@suse.com>
* feat: add feature falg to hide vGPU enable/disable actions in PCIDevices page
Signed-off-by: Andy Lee <andy.lee@suse.com>
* refactor: update with conditionally rendering
Signed-off-by: Andy Lee <andy.lee@suse.com>
---------
Signed-off-by: Andy Lee <andy.lee@suse.com>