public/harvester-ui-extension
1
0
Fork 0
mirror of https://github.com/harvester/harvester-ui-extension.git synced 2025-12-13 21:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: featureFlags is undefined when installing lower version of ui-ext (#443) (#446)

Browse Source 
* fix: featureFlags is undefined if install lower version of ui-ext

Signed-off-by: Andy Lee <andy.lee@suse.com>

(cherry picked from commit 182d92d80bbc21fba9f48f0a17f332305eb93851)

Co-authored-by: Andy Lee <andy.lee@suse.com>
This commit is contained in:
mergify[bot] 2025-08-01 15:41:33 +08:00 committed by GitHub
parent 59c63c8d9e
commit acbc120dc1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pkg/harvester/utils/feature-flags.js
View File

@ -8,7 +8,6 @@ export const docLink = (suffix, version) => {
}; };
export function getVersion(v) { export function getVersion(v) {
// e.g v1.4.0
if (process.env.VUE_APP_SERVER_VERSION) { if (process.env.VUE_APP_SERVER_VERSION) {
return process.env.VUE_APP_SERVER_VERSION; return process.env.VUE_APP_SERVER_VERSION;
} }
@ -18,20 +17,21 @@ export function getVersion(v) {
return `v${ semver.major(v) }.${ semver.minor(v) }.${ semver.patch(v) }`; return `v${ semver.major(v) }.${ semver.minor(v) }.${ semver.patch(v) }`;
} catch (error) { } catch (error) {
// fallback to the latest version // fallback to the latest version
return latestVersion(Object.keys(RELEASE_FEATURES)); return getLatestVersion();
} }
} }
function latestVersion(versions) { function getLatestVersion() {
return versions.sort((a, b) => semver.compare(a, b)).pop(); const allVersions = Object.keys(RELEASE_FEATURES).filter(semver.valid).sort(semver.rcompare);
return allVersions[0] || '';
} }
// v1.3.3 => latest v1.3.x, v1.4.2 => latest v1.4.x function getLatestCompatibleVersion(version) {
function latestMinorVersion(v) { const allVersions = Object.keys(RELEASE_FEATURES).filter(semver.valid);
const minor = `v${ semver.major(v) }.${ semver.minor(v) }`; const compatible = allVersions.filter((v) => semver.lte(v, version)).sort(semver.rcompare);
const minorVersions = Object.keys(RELEASE_FEATURES).filter((version) => version.startsWith(minor));
return latestVersion(minorVersions); return compatible[0] || getLatestVersion();
} }
export const featureEnabled = (featureKey, serverVersion) => { export const featureEnabled = (featureKey, serverVersion) => {
@ -46,12 +46,16 @@ export const featureEnabled = (featureKey, serverVersion) => {
return false; return false;
} }
let releasedFeatures = RELEASE_FEATURES[version]; const compatibleVersion = getLatestCompatibleVersion(version);
const releasedFeatures = RELEASE_FEATURES?.[compatibleVersion];
if (!releasedFeatures) { if (!Array.isArray(releasedFeatures)) {
const fallback = latestMinorVersion(version); // eslint-disable-next-line no-console
console.error(
`Feature flags for version ${ version } are not defined. Please upgrade Harvester UI extension and check the support matrix.`
);
releasedFeatures = RELEASE_FEATURES[fallback]; return false;
} }
return releasedFeatures.includes(featureKey); return releasedFeatures.includes(featureKey);