mirror of
https://github.com/harvester/harvester-ui-extension.git
synced 2026-11-22 08:37:38 +08:00
Add a StorageClass selector to online and air-gapped upgrade pages when
the repositoryStorageClass feature is enabled (v1.10+).
- Online: stores selection in harvesterhci.io/upgrade-storage-class annotation
- Air-gapped: stores selection in image spec.targetStorageClassName
- Selector locked while uploaded image exists; unlocked on switch to URL
- Hidden on pre-v1.10 clusters
(cherry picked from commit aa5a501c29)
Signed-off-by: pohanhuang <pohan.huang@suse.com>
Co-authored-by: Po Han Huang <pohan.huang@suse.com>
This commit is contained in:
1 parent
ff0a6c8431
commit
8ac059b2d6
10 files changed
+475
-12
No files matched your search
@@ -0,0 +1,86 @@
|
||||
import { HCI as HCI_ANNOTATIONS } from '@pkg/harvester/config/labels-annotations';
|
||||
import HarvesterUpgrade from '../HarvesterUpgrade.vue';
|
||||
|
||||
const save = jest.fn().mockResolvedValue();
|
||||
const upgrade = { notifyGeneratedName: jest.fn(), save };
|
||||
|
||||
function createForm(storageClassName = '', repositoryStorageClassEnabled = true) {
|
||||
return {
|
||||
version: 'v1.10.0',
|
||||
storageClassName,
|
||||
repositoryStorageClassEnabled,
|
||||
canEnableLogging: false,
|
||||
enableLogging: true,
|
||||
skipSingleReplicaDetachedVolFeatureEnabled: false,
|
||||
skipSingleReplicaDetachedVol: false,
|
||||
cancel: jest.fn(),
|
||||
errors: '',
|
||||
$store: { dispatch: jest.fn().mockResolvedValue(upgrade) }
|
||||
};
|
||||
}
|
||||
|
||||
describe('component: HarvesterUpgrade', () => {
|
||||
it('uses the shared Upgrade Repository StorageClass selector', () => {
|
||||
expect(HarvesterUpgrade.components.UpgradeRepositoryStorageClass).toBeDefined();
|
||||
});
|
||||
|
||||
it('leaves the default empty when it is unavailable for upgrade repositories', async() => {
|
||||
const form = {
|
||||
upgrade: [],
|
||||
storageClassName: 'previous',
|
||||
$store: {
|
||||
getters: { currentProduct: { inStore: 'harvester' } },
|
||||
dispatch: jest.fn()
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce([])
|
||||
.mockResolvedValueOnce([
|
||||
{
|
||||
name: 'lvm-local', isDefault: true, provisioner: 'lvm.driver.harvesterhci.io'
|
||||
},
|
||||
{ name: 'fast' }
|
||||
])
|
||||
}
|
||||
};
|
||||
|
||||
await HarvesterUpgrade.fetch.call(form);
|
||||
|
||||
expect(form.storageClassName).toBe('');
|
||||
});
|
||||
|
||||
it('blocks the upgrade when no StorageClass is selected', () => {
|
||||
const canSubmitUpgrade = HarvesterUpgrade.computed.canSubmitUpgrade;
|
||||
|
||||
expect(canSubmitUpgrade.call({
|
||||
readyReleaseNote: true,
|
||||
repositoryStorageClassEnabled: true,
|
||||
storageClassName: ''
|
||||
})).toBe(false);
|
||||
});
|
||||
|
||||
it('saves the selected StorageClass as an Upgrade annotation', async() => {
|
||||
const form = createForm('fast');
|
||||
|
||||
await HarvesterUpgrade.methods.handleUpgrade.call(form);
|
||||
|
||||
expect(form.$store.dispatch).toHaveBeenCalledWith('harvester/create', expect.objectContaining({
|
||||
metadata: expect.objectContaining({ annotations: { [HCI_ANNOTATIONS.UPGRADE_STORAGE_CLASS]: 'fast' } }),
|
||||
spec: { version: 'v1.10.0' }
|
||||
}));
|
||||
});
|
||||
|
||||
it('omits the repository StorageClass when the feature is disabled', async() => {
|
||||
const form = createForm('fast', false);
|
||||
|
||||
await HarvesterUpgrade.methods.handleUpgrade.call(form);
|
||||
|
||||
expect(form.$store.dispatch).toHaveBeenCalledWith('harvester/create', {
|
||||
type: 'harvesterhci.io.upgrade',
|
||||
metadata: {
|
||||
generateName: 'hvst-upgrade-',
|
||||
namespace: 'harvester-system'
|
||||
},
|
||||
spec: { version: 'v1.10.0' }
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,40 @@
|
||||
import UpgradeRepositoryStorageClass, { getUpgradeRepositoryStorageClassDefault } from '../UpgradeRepositoryStorageClass.vue';
|
||||
|
||||
const storageClasses = [
|
||||
{ name: 'fast', isDefault: true },
|
||||
{ name: 'image-cache', parameters: { backingImage: 'image' } },
|
||||
{ name: 'lvm-local', provisioner: 'lvm.driver.harvesterhci.io' },
|
||||
{ name: 'longhorn-static' },
|
||||
{ name: 'slow' }
|
||||
];
|
||||
|
||||
describe('component: UpgradeRepositoryStorageClass', () => {
|
||||
it('omits backing-image and LVM StorageClasses while disabling internal classes', () => {
|
||||
const form = {
|
||||
storageClasses,
|
||||
$store: { getters: { 'i18n/t': (key) => key } }
|
||||
};
|
||||
|
||||
expect(UpgradeRepositoryStorageClass.computed.storageClassOptions.call(form)).toStrictEqual([
|
||||
{
|
||||
label: 'fast (generic.default)', value: 'fast', disabled: false
|
||||
},
|
||||
{
|
||||
label: 'longhorn-static (harvester.storage.internal.label)', value: 'longhorn-static', disabled: true
|
||||
},
|
||||
{
|
||||
label: 'slow', value: 'slow', disabled: false
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
it('does not use an unavailable StorageClass as the default', () => {
|
||||
expect(getUpgradeRepositoryStorageClassDefault([
|
||||
{
|
||||
name: 'lvm-local', isDefault: true, provisioner: 'lvm.driver.harvesterhci.io'
|
||||
},
|
||||
{ name: 'longhorn-static' },
|
||||
{ name: 'fast' }
|
||||
])).toBe('');
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user