public/harvester-ui-extension
1
0
Fork 0
mirror of https://github.com/harvester/harvester-ui-extension.git synced 2025-12-13 21:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

add feature flag config

Browse Source
This commit is contained in:
andy.lee 2024-11-07 15:44:20 +08:00 committed by Francesco Torchia
parent aa3c9268e3
commit 77d7f13836
No known key found for this signature in database
GPG Key ID: E6D011B7415D4393
7 changed files with 107 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
pkg/harvester/config/feature-flags.js Normal file
View File

@ -0,0 +1,54 @@
// https://github.com/harvester/harvester/wiki/Roadmap
const FEATURES = {
cpuPinning: false,
usbPassthrough: false,
volumeEncryption: false,
schedulingVMBackup: false,
vmSnapshotQuota: false,
longhornV2LVMSupport: false,
improveMaintainMode: false,
autoRotateRke2CertsSetting: false,
kubeconfigDefaultTokenTTLMinutesSetting: false,
supportBundleNodeCollectionTimeoutSetting: false
};
// https://github.com/harvester/dashboard/releases/tag/v1.3.0
const releaseV130 = { ...FEATURES };
// https://github.com/harvester/dashboard/releases/tag/v1.3.1
const releaseV131 = {
...releaseV130,
autoRotateRke2CertsSetting: true,
supportBundleNodeCollectionTimeoutSetting: true
};
// https://github.com/harvester/dashboard/releases/tag/v1.3.2
const releaseV132 = {
...releaseV131,
kubeconfigDefaultTokenTTLMinutesSetting: true,
};
// TODO: change to https://github.com/harvester/dashboard/releases/tag/v1.4.0 after v1.4.0 release
// https://github.com/harvester/dashboard/releases/tag/v1.4.0-rc5
// https://github.com/harvester/dashboard/releases/tag/v1.4.0-rc4
// https://github.com/harvester/dashboard/releases/tag/v1.4.0-rc3
// https://github.com/harvester/dashboard/releases/tag/v1.4.0-rc2
// https://github.com/harvester/dashboard/releases/tag/v1.4.0-rc1
const releaseV140 = {
...releaseV132,
cpuPinning: true,
usbPassthrough: true,
volumeEncryption: true,
schedulingVMBackup: true,
vmSnapshotQuota: true,
longhornV2LVMSupport: true,
improveMaintainMode: true,
};
export const RELEASE_FEATURES = {
'v1.4.0': releaseV140,
'v1.3.2': releaseV132,
'v1.3.1': releaseV132,
'v1.3.0': releaseV130,
};

2
pkg/harvester/detail/harvesterhci.io.host/HarvesterHostBasic.vue
View File

@ -247,7 +247,7 @@ export default {
<div class="row mb-20">
<div
v-if="!value.isEtcd"
v-if="!value.isEtcd && value.isCPUManagerEnabled"
class="col span-6"
>
<LabelValue

5
pkg/harvester/edit/kubevirt.io.virtualmachine/index.vue
View File

@ -197,6 +197,10 @@ export default {
},
showCpuPinningBanner() {
if (!this.value.cpuPinningFeatureEnabled) {
return false;
}
if (this.mode === 'edit') {
return this.cpuPinning !== !!this.cloneVM.spec.template.spec.domain.cpu.dedicatedCpuPlacement;
}
@ -832,6 +836,7 @@ export default {
/>
<Checkbox
v-if="value.cpuPinningFeatureEnabled"
v-model:value="cpuPinning"
:disabled="!enableCpuPinningCheckbox"
class="check"

23
pkg/harvester/list/harvesterhci.io.host.vue
View File

@ -128,18 +128,17 @@ export default {
out.splice(-1, 0, storageHeader);
}
out.push({
name: 'cpuManager',
labelKey: 'harvester.tableHeaders.cpuManager',
value: 'id',
formatter: 'HarvesterCPUPinning',
formatterOpts: { rows: this.rows },
width: 150,
align: 'center',
});
if (this.rows.every((node) => node.cpuPinningFeatureEnabled)) {
out.push({
name: 'cpuManager',
labelKey: 'harvester.tableHeaders.cpuManager',
value: 'id',
formatter: 'HarvesterCPUPinning',
formatterOpts: { rows: this.rows },
width: 150,
align: 'center',
});
}
if (this.hasLonghornSchema) {
out.push({
name: 'diskState',

10
pkg/harvester/models/harvester/node.js
View File

@ -14,8 +14,8 @@ import { findBy, isArray } from '@shell/utils/array';
import { ucFirst } from '@shell/utils/string';
import HarvesterResource from '../harvester';
import { PRODUCT_NAME as HARVESTER_PRODUCT } from '../../config/harvester';
import { HCI } from '../../types';
import { featureEnabled } from '../../utils/server';
const ALLOW_SYSTEM_LABEL_KEYS = [
'topology.kubernetes.io/zone',
@ -61,7 +61,7 @@ export default class HciNode extends HarvesterResource {
const enableCPUManager = {
action: 'enableCPUManager',
enabled: this.hasAction('enableCPUManager') && !this.isCPUManagerEnableInProgress && !this.isCPUManagerEnabled && !this.isEtcd, // witness node doesn't have CPU manager
enabled: this.cpuPinningFeatureEnabled && this.hasAction('enableCPUManager') && !this.isCPUManagerEnableInProgress && !this.isCPUManagerEnabled && !this.isEtcd, // witness node doesn't have CPU manager
icon: 'icon icon-fw icon-os-management',
label: this.t('harvester.action.enableCPUManager'),
total: 1
@ -69,7 +69,7 @@ export default class HciNode extends HarvesterResource {
const disableCPUManager = {
action: 'disableCPUManager',
enabled: this.hasAction('disableCPUManager') && !this.isCPUManagerEnableInProgress && this.isCPUManagerEnabled && !this.isEtcd,
enabled: this.cpuPinningFeatureEnabled && this.hasAction('disableCPUManager') && !this.isCPUManagerEnableInProgress && this.isCPUManagerEnabled && !this.isEtcd,
icon: 'icon icon-fw icon-os-management',
label: this.t('harvester.action.disableCPUManager'),
total: 1
@ -370,6 +370,10 @@ export default class HciNode extends HarvesterResource {
);
}
get cpuPinningFeatureEnabled() {
return featureEnabled(this.$rootGetters, 'cpuPinning');
}
get isCPUManagerEnabled() {
return this.metadata?.labels?.[HCI_ANNOTATIONS.CPU_MANAGER] === 'true';
}

5
pkg/harvester/models/kubevirt.io.virtualmachine.js
View File

@ -14,6 +14,7 @@ import { BACKUP_TYPE } from '../config/types';
import { HCI } from '../types';
import HarvesterResource from './harvester';
import { LVM_DRIVER } from './harvester/storage.k8s.io.storageclass';
import { featureEnabled } from '../utils/server';
export const OFF = 'Off';
@ -480,6 +481,10 @@ export default class VirtVm extends HarvesterResource {
return null;
}
get cpuPinningFeatureEnabled() {
return featureEnabled(this.$rootGetters, 'cpuPinning');
}
get isCpuPinning() {
return this.spec?.template?.spec?.domain?.cpu?.dedicatedCpuPlacement === true;
}

24
pkg/harvester/utils/server.js Normal file
View File

@ -0,0 +1,24 @@
import semver from 'semver';
import { HCI } from '../types';
import { RELEASE_FEATURES } from '../config/feature-flags';
export function serverVersion(getters) {
// e.g v1.4.0
if (process.env.VUE_APP_SERVER_VERSION) {
return process.env.VUE_APP_SERVER_VERSION;
}
try {
const v = getters['harvester/byId'](HCI.SETTING, 'server-version')?.value;
return `v${ semver.major(v) }.${ semver.minor(v) }.${ semver.patch(v) }`;
} catch (error) {}
return '';
}
export const featureEnabled = (getters, featureKey) => {
const version = serverVersion(getters);
return !!RELEASE_FEATURES[version]?.[featureKey] || false;
};