From 580b2892cb82c01a48b9edd079af77a471d16bb9 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Wed, 28 May 2025 13:00:40 +0800 Subject: [PATCH] fix upgrade button status if have errors (#316) (#321) (cherry picked from commit cb452b962794b38105626b3d55ce6bcdf6e01ee6) Co-authored-by: Andy Lee --- .../pages/c/_cluster/airgapupgrade/index.vue | 24 ++----------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/pkg/harvester/pages/c/_cluster/airgapupgrade/index.vue b/pkg/harvester/pages/c/_cluster/airgapupgrade/index.vue index c11ff72f..8dc39290 100644 --- a/pkg/harvester/pages/c/_cluster/airgapupgrade/index.vue +++ b/pkg/harvester/pages/c/_cluster/airgapupgrade/index.vue @@ -212,28 +212,6 @@ export default { } try { - if (this.deleteExistImage) { - // if not select image, show error - if (!this.deleteImageId) { - this.errors.push(this.$store.getters['i18n/t']('harvester.setting.upgrade.deleteImage')); - buttonCb(false); - - return; - } - - // if select image, delete image - const image = this.$store.getters['harvester/byId'](HCI.IMAGE, this.deleteImageId); - - if (image) { - this.handleImageDelete(image); - buttonCb(true); - - return; - } - - return; - } - if (this.imageSource === IMAGE_METHOD.NEW) { this.imageValue.metadata.annotations[HCI_ANNOTATIONS.OS_UPGRADE_IMAGE] = 'True'; @@ -241,6 +219,7 @@ export default { this.value.spec.image = this.uploadImageId; } else if (this.sourceType === DOWNLOAD) { this.imageValue.spec.sourceType = DOWNLOAD; + if (!this.imageValue.spec.url) { this.errors.push(this.$store.getters['i18n/t']('harvester.setting.upgrade.imageUrl')); buttonCb(false); @@ -254,6 +233,7 @@ export default { } else if (this.imageSource === IMAGE_METHOD.EXIST) { if (!this.imageId) { this.errors.push(this.$store.getters['i18n/t']('harvester.setting.upgrade.chooseFile')); + buttonCb(false); return; }