public/harvester-ui-extension
1
0
Fork 0
mirror of https://github.com/harvester/harvester-ui-extension.git synced 2025-12-13 21:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move logic to node model

Browse Source 
Signed-off-by: Yi-Ya Chen <yiya.chen@suse.com>
This commit is contained in:
Yi-Ya Chen 2025-01-14 16:16:56 +08:00
parent c791399a61
commit 43b10b250e
No known key found for this signature in database
GPG Key ID: 9A2E6FBD33F68EDE
2 changed files with 47 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
pkg/harvester/list/harvesterhci.io.host.vue
View File

@ -3,7 +3,7 @@ import ResourceTable from '@shell/components/ResourceTable';
import Loading from '@shell/components/Loading';
import { STATE, NAME, AGE } from '@shell/config/table-headers';
import {
CAPI, METRIC, NODE, SCHEMA, LONGHORN, POD, MANAGEMENT, NORMAN
CAPI, METRIC, NODE, SCHEMA, LONGHORN, POD
} from '@shell/config/types';
import { allHash } from '@shell/utils/promise';
import metricPoller from '@shell/mixins/metric-poller';
@ -62,42 +62,8 @@ export default {
_hash.machines = this.$store.dispatch(`${ inStore }/findAll`, { type: CAPI.MACHINE });
}
if (
this.$store.getters['rancher/schemaFor'](NORMAN.PRINCIPAL) &&
this.$store.getters['rancher/schemaFor'](NORMAN.CLUSTER_ROLE_TEMPLATE_BINDING)
) {
_hash.normanPrincipal = this.$store.dispatch('rancher/findAll', { type: NORMAN.PRINCIPAL });
_hash.clusterRoleTemplateBinding = this.$store.dispatch(`management/findAll`, { type: MANAGEMENT.CLUSTER_ROLE_TEMPLATE_BINDING });
}
const hash = await allHash(_hash);
// Remove delete action if current user role is cluster member
if (hash.normanPrincipal && hash.clusterRoleTemplateBinding) {
const role = hash.clusterRoleTemplateBinding.find(
(template) => template.userPrincipalName === hash.normanPrincipal[0]?.id
);
const isClusterMember = role?.roleTemplateName === 'cluster-member';
if (isClusterMember) {
hash.nodes = hash.nodes.map((node) => {
const updatedActions = node.availableActions.map((action) => {
return action.action === 'promptRemove' ? { ...action, enabled: false } : action;
});
// keep availableActions non-enumerable
Object.defineProperty(node, 'availableActions', {
value: updatedActions,
writable: true,
enumerable: false,
configurable: true,
});
return node;
});
}
}
this.rows = hash.nodes;
},

48
pkg/harvester/models/harvester/node.js
View File

@ -1,5 +1,5 @@
import pickBy from 'lodash/pickBy';
import { CAPI, LONGHORN, POD, NODE } from '@shell/config/types';
import { CAPI, LONGHORN, POD, NODE, NORMAN } from '@shell/config/types';
import { CAPI as CAPI_ANNOTATIONS } from '@shell/config/labels-annotations.js';
import { HCI as HCI_ANNOTATIONS } from '@pkg/harvester/config/labels-annotations';
import { clone } from '@shell/utils/object';
@ -25,7 +25,17 @@ const HEALTHY = 'healthy';
const WARNING = 'warning';
export default class HciNode extends HarvesterResource {
constructor(...args) {
super(...args);
this._roleBasedActions = [];
this._initialized = false; // flag to prevent repeated initialization
}
get _availableActions() {
if (!this._initialized) {
this.setupRoleBasedActions();
}
const cordon = {
action: 'cordon',
enabled: this.hasAction('cordon') && !this.isCordoned,
@ -108,10 +118,44 @@ export default class HciNode extends HarvesterResource {
shutDown,
powerOn,
reboot,
...super._availableActions
...this._roleBasedActions || []
];
}
async setupRoleBasedActions() {
const baseActions = super._availableActions || [];
// access control is only available on the multiple cluster Harvester
if (this.$rootGetters['isStandaloneHarvester']) {
this._roleBasedActions = baseActions;
} else {
this._roleBasedActions = await this._updateRoleBasedActions(baseActions);
}
this._initialized = true;
}
async _updateRoleBasedActions(actions) {
const hasSchema = (type) => this.$rootGetters['rancher/schemaFor'](type);
if (!hasSchema(NORMAN.PRINCIPAL) || !hasSchema(NORMAN.CLUSTER_ROLE_TEMPLATE_BINDING)) return actions;
try {
const templates = await this.$dispatch('rancher/findAll', { type: NORMAN.CLUSTER_ROLE_TEMPLATE_BINDING }, { root: true });
const [currentUser] = this.$rootGetters['rancher/all'](NORMAN.PRINCIPAL) || [];
const userRole = templates.find((template) => template.userPrincipalId === currentUser?.id);
if (userRole?.roleTemplateId === 'cluster-member') {
return actions.filter((action) => action.action !== 'promptRemove');
}
} catch (error) {
// eslint-disable-next-line no-console
console.error('Error fetching role-based actions:', error);
}
return actions;
}
promptRemove(resources = this) {
this.$dispatch('promptModal', {
resources,