diff --git a/pkg/harvester/components/settings/__tests__/upgrade-config.test.js b/pkg/harvester/components/settings/__tests__/upgrade-config.test.js new file mode 100644 index 00000000..591abd56 --- /dev/null +++ b/pkg/harvester/components/settings/__tests__/upgrade-config.test.js @@ -0,0 +1,79 @@ +import { shallowMount } from '@vue/test-utils'; +import UpgradeConfig from '@pkg/harvester/components/settings/upgrade-config.vue'; + +const DEFAULT = JSON.stringify({ + imagePreloadOption: { strategy: { type: 'sequential' } }, + nodeUpgradeOption: { strategy: { mode: 'auto' } }, + restoreVM: false, +}); + +const mountConfig = (config, featureEnabled) => shallowMount(UpgradeConfig, { + props: { + mode: 'edit', + value: { default: DEFAULT, value: config ? JSON.stringify(config) : '' }, + }, + global: { + mocks: { + $store: { + dispatch: jest.fn(), + getters: { + currentProduct: { inStore: 'harvester' }, + 'harvester/all': () => [], + 'i18n/t': (key) => key, + 'harvester-common/getFeatureEnabled': (name) => name === 'shutdownVMOnMigrationFailure' && featureEnabled, + }, + }, + }, + }, +}); + +const savedValue = (wrapper) => JSON.parse(wrapper.props('value').value); + +describe('component: upgrade-config', () => { + it('should default shutdownVMOnMigrationFailure to false when the field is missing', () => { + const wrapper = mountConfig(undefined, true); + + expect(savedValue(wrapper).shutdownVMOnMigrationFailure).toBe(false); + expect(wrapper.findComponent('[name="shutdownVMOnMigrationFailure"]').exists()).toBe(true); + }); + + it('should keep an enabled shutdownVMOnMigrationFailure', () => { + const wrapper = mountConfig({ shutdownVMOnMigrationFailure: true }, true); + + expect(savedValue(wrapper).shutdownVMOnMigrationFailure).toBe(true); + }); + + it('should save the value selected in its radio group', async() => { + const wrapper = mountConfig(undefined, true); + + await wrapper.findComponent('[name="shutdownVMOnMigrationFailure"]').vm.$emit('update:value', true); + + expect(savedValue(wrapper).shutdownVMOnMigrationFailure).toBe(true); + expect(savedValue(wrapper).restoreVM).toBe(false); + + await wrapper.findComponent('[name="restoreVM"]').vm.$emit('update:value', true); + + expect(savedValue(wrapper).shutdownVMOnMigrationFailure).toBe(true); + expect(savedValue(wrapper).restoreVM).toBe(true); + }); + + it('should name the radio groups for screen readers', () => { + const wrapper = mountConfig(undefined, true); + + expect(wrapper.findComponent('[name="restoreVM"]').attributes('aria-label')).toBe('harvester.setting.upgrade.restoreVM'); + expect(wrapper.findComponent('[name="shutdownVMOnMigrationFailure"]').attributes('aria-label')).toBe('harvester.setting.upgrade.shutdownVMOnMigrationFailure'); + }); + + it('should hide the control and not add the field on clusters without the feature', () => { + const wrapper = mountConfig(undefined, false); + + expect(savedValue(wrapper)).not.toHaveProperty('shutdownVMOnMigrationFailure'); + expect(wrapper.findComponent('[name="shutdownVMOnMigrationFailure"]').exists()).toBe(false); + }); + + it('should keep a field set outside the UI on clusters without the feature', () => { + const wrapper = mountConfig({ shutdownVMOnMigrationFailure: true }, false); + + expect(savedValue(wrapper).shutdownVMOnMigrationFailure).toBe(true); + }); +}); diff --git a/pkg/harvester/components/settings/upgrade-config.vue b/pkg/harvester/components/settings/upgrade-config.vue index f8980edf..0e2637d3 100644 --- a/pkg/harvester/components/settings/upgrade-config.vue +++ b/pkg/harvester/components/settings/upgrade-config.vue @@ -74,6 +74,10 @@ export default { }, methods: { + // A method, as normalizeValue also runs in data(), before computed properties are available + shutdownVMOnMigrationFailureEnabled() { + return this.$store.getters['harvester-common/getFeatureEnabled']('shutdownVMOnMigrationFailure'); + }, normalizeValue(obj) { // handle nodeUpgradeOption.strategy if (obj?.nodeUpgradeOption?.strategy?.mode === 'auto') { @@ -107,6 +111,9 @@ export default { if (typeof obj.restoreVM !== 'boolean') { obj.restoreVM = false; } + if (this.shutdownVMOnMigrationFailureEnabled() && typeof obj.shutdownVMOnMigrationFailure !== 'boolean') { + obj.shutdownVMOnMigrationFailure = false; + } return obj; }, @@ -179,10 +186,24 @@ export default { v-model:value="parseDefaultValue.restoreVM" class="mb-20" name="restoreVM" + :aria-label="t('harvester.setting.upgrade.restoreVM')" :options="[true, false]" :labels="[t('generic.enabled'), t('generic.disabled')]" @update:value="update" /> +
+ + +